Skip to content

Add a bool return to _grantRole and _revokeRole #4241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Amxx merged 7 commits into from
Aug 1, 2023
Merged

Add a bool return to _grantRole and _revokeRole #4241

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c41f431
Add a bool return to _grantRole and _revokeRole
Amxx May 17, 2023
d32c800
Merge branch 'master' into improve/AccessControl/internal-return-bool
ernestognw Jul 6, 2023
0efefd8
Add changeset
ernestognw Jul 6, 2023
47d0345
add tests
Amxx Jul 7, 2023
917d743
update natspec comments
Amxx Jul 7, 2023
3939cb4
Apply suggestions from code review
Amxx Jul 7, 2023
7dc7e62
Merge branch 'master' into improve/AccessControl/internal-return-bool
Amxx Jul 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add changeset
  • Loading branch information
@ernestognw
ernestognw committed Jul 6, 2023
commit 0efefd878f3cdac7a69b4dd16f0cc0da5da66970
5 changes: 5 additions & 0 deletions .changeset/two-wasps-punch.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'openzeppelin-solidity': minor
---

`AccessControl`: Add a boolean return value to the internal `_grantRole` and `_revokeRole` functions indicating whether the role was granted or revoked.