-
Notifications
You must be signed in to change notification settings - Fork 12.4k
Remove code in preparation for v5.0 #4258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 17 commits
cd07e1b
42b3aef
ff68a57
18e63a7
64bf67c
aeb12fa
0ea8756
3344612
5624e52
0a3ccc2
f3e4e14
a06d55f
a949b62
6831f92
7b385c6
cd0407f
edc27fe
69c5dee
c974e7f
d39ab48
b2be20e
f714926
15639d7
e519bc3
2cd0d41
815bf2a
a19eb6a
d0e778f
932ae59
b9991cc
4d11483
32b6b60
e21211b
9456fce
2d2e8fa
9193cea
41732d3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| 'openzeppelin-solidity': major | ||
| --- | ||
|
|
||
| Remove deprecated GovernorProposalThreshold module. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| 'openzeppelin-solidity': major | ||
| --- | ||
|
|
||
| Remove ERC1820Implementer. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| 'openzeppelin-solidity': major | ||
| --- | ||
|
|
||
| Remove Escrow constracts (Escrow, ConditionalEscrow, RefundEscrow and PullPayment). | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| 'openzeppelin-solidity': major | ||
| --- | ||
|
|
||
| Remove the Timers library. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| 'openzeppelin-solidity': major | ||
| --- | ||
|
|
||
| Remove ERC777 implementation. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| 'openzeppelin-solidity': major | ||
| --- | ||
|
|
||
| Remove CrossChain contracts, including AccessControlCrossChain and all the vendored bridge interfaces. |
This file was deleted.
This file was deleted.
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We need to explain the rationale for some of these removals, I think particularly this one, perhaps both in the PR description and the changesets/changelog.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So what's the rationale? There's none in the PR description and the changelog only states the removal 😆 Are these bridges or the removed contracts unsafe? Did universal bridges become so good that there's no reason to support custom ones?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The rationale is basically that the contracts had really low usage and the Crosschain landscape went in a different direction, this includes other bridges' technology and use cases. I think the changeset is fine as it is right now, perhaps some of these notes may be added to the changelog in a different fashion other than a changeset entry. |
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.