Skip to content

Replace abi.encodeWithSelector & abi.encodeWithSignature with abi.encodeCall #4293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frangio merged 5 commits into from
Jun 6, 2023
Merged

Replace abi.encodeWithSelector & abi.encodeWithSignature with abi.encodeCall #4293

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ef91e28
feat: replaces abi.encodeWithSelector & abi.encodeWithSignature with …
balajipachai May 31, 2023
f171e6f
Merge branch 'master' into replace-abi-encodewithselector-with-abi-en…
balajipachai May 31, 2023
d281193
chore: updates changeset
balajipachai Jun 1, 2023
653cf08
Update big-plums-cover.md
Amxx Jun 1, 2023
c2fbbde
Update test/utils/ShortStrings.t.sol
balajipachai Jun 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update test/utils/ShortStrings.t.sol 
Co-authored-by: Hadrien Croubois <[email protected]>
  • Loading branch information
@balajipachai @Amxx
balajipachai and Amxx authored Jun 1, 2023
commit c2fbbded6dc33367dff46f9ddc104271d908e55d
2 changes: 1 addition & 1 deletion test/utils/ShortStrings.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ contract ShortStringsTest is Test {

function testRevertLong(string memory input) external {
vm.assume(!_isShort(input));
vm.expectRevert(abi.encodeCall(ShortStrings.StringTooLong, (input)));
vm.expectRevert(abi.encodeWithSelector(ShortStrings.StringTooLong.selector, input));
this.toShortString(input);
}

Expand Down