Skip to content

Optimize array access in ERC1155 #4300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frangio merged 9 commits into from
Jun 15, 2023
Merged

Optimize array access in ERC1155 #4300

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
68a6eaf
add unsafe memory access function and refactor erc1155 to use it
clauBv23 May 31, 2023
60f8ccf
Merge branch 'master' into ERC1155-array-unsafe-memory-access-optimiz…
clauBv23 Jun 2, 2023
52c5cd6
add changeset
clauBv23 Jun 2, 2023
02d57d1
fix extra lines
clauBv23 Jun 2, 2023
686e4f9
Apply suggestions from code review
Amxx Jun 9, 2023
78f93a8
Update .changeset/hot-coins-judge.md
clauBv23 Jun 9, 2023
da36cad
add docs
frangio Jun 15, 2023
c57b221
Merge branch 'master' into ERC1155-array-unsafe-memory-access-optimiz…
frangio Jun 15, 2023
f25df97
update changesets
frangio Jun 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add docs
  • Loading branch information
@frangio
frangio committed Jun 15, 2023
commit da36cad1b416d5d7410cb46bd7d4818e2d398217
10 changes: 10 additions & 0 deletions contracts/utils/Arrays.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,12 +103,22 @@ library Arrays {
return slot.getUint256Slot();
}

/**
* @dev Access an array in an "unsafe" way. Skips solidity "index-out-of-range" check.
*
* WARNING: Only use if you are certain `pos` is lower than the array length.
*/
function unsafeMemoryAccess(uint256[] memory arr, uint256 pos) internal pure returns (uint256 res) {
assembly {
res := mload(add(add(arr, 0x20), mul(pos, 0x20)))
}
}

/**
* @dev Access an array in an "unsafe" way. Skips solidity "index-out-of-range" check.
*
* WARNING: Only use if you are certain `pos` is lower than the array length.
*/
function unsafeMemoryAccess(address[] memory arr, uint256 pos) internal pure returns (address res) {
assembly {
res := mload(add(add(arr, 0x20), mul(pos, 0x20)))
Expand Down