Skip to content

Change behavior of ceilDiv(0, 0) and improve test coverage #4348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frangio merged 2 commits into from
Jun 14, 2023
Merged

Change behavior of ceilDiv(0, 0) and improve test coverage #4348

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c85169f
Improve tests after custom errors
ernestognw Jun 14, 2023
1c02d6b
Add changeset
ernestognw Jun 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add changeset
  • Loading branch information
@ernestognw
ernestognw committed Jun 14, 2023
commit 1c02d6b0cfb6e82bba4ca17f6fc149fd68ef1121
5 changes: 5 additions & 0 deletions .changeset/blue-scissors-design.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'openzeppelin-solidity': minor
---

`Math`: Make `ceilDiv` to revert on 0 division even if the numerator is 0
Copy link
Collaborator

@Amxx Amxx Jun 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its actually a panic. But this is already merge so whatever.

Copy link
Contributor

@frangio frangio Jun 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changeset is correct, it reverts with a Panic error.