Skip to content

Make TransparentUpgradeableProxy admin immutable #4354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ernestognw merged 18 commits into from
Jun 20, 2023
Merged

Make TransparentUpgradeableProxy admin immutable #4354

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
045ed4f
Make TransparentUpgradeable proxy admin immutable
ernestognw Jun 15, 2023
223c8a7
Add changeset
ernestognw Jun 15, 2023
e102ddb
Add solhint note
ernestognw Jun 15, 2023
456d6ee
Codespell
ernestognw Jun 15, 2023
1fda92a
Update contracts/proxy/transparent/TransparentUpgradeableProxy.sol
ernestognw Jun 15, 2023
5ad12bf
Merge branch 'master' into lib-805-transparent-proxy-immutable-admin
ernestognw Jun 15, 2023
4af8379
Apply suggestions
ernestognw Jun 15, 2023
f8d926f
Doc changes
ernestognw Jun 15, 2023
b824829
Improvements to the docs
ernestognw Jun 15, 2023
b04e343
Simplified test
ernestognw Jun 15, 2023
04a087d
Reword
ernestognw Jun 15, 2023
56f72af
Merge branch 'master' into lib-805-transparent-proxy-immutable-admin
ernestognw Jun 15, 2023
479fd78
Update .changeset/happy-falcons-walk.md
ernestognw Jun 16, 2023
6df9005
Rename unsafeOverrideAdmin
ernestognw Jun 16, 2023
8926ea7
Update .changeset/happy-falcons-walk.md
ernestognw Jun 16, 2023
1e33092
Merge branch 'master' into lib-805-transparent-proxy-immutable-admin
Amxx Jun 17, 2023
9ce6f4b
fix test description
frangio Jun 20, 2023
57e6869
extend comment with further explanation
frangio Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update contracts/proxy/transparent/TransparentUpgradeableProxy.sol 
Co-authored-by: Hadrien Croubois <[email protected]>
  • Loading branch information
@ernestognw @Amxx
ernestognw and Amxx authored Jun 15, 2023
commit 1fda92ac76d56dc461d615fe426be0bc1d2f6585
2 changes: 1 addition & 1 deletion contracts/proxy/transparent/TransparentUpgradeableProxy.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ interface ITransparentUpgradeableProxy is IERC1967 {
contract TransparentUpgradeableProxy is ERC1967Proxy {
// An immutable address for the admin avoid unnecessary SLOADs before each call
// at the expense of removing the ability to change the admin once it's set.
address immutable _admin;
address private immutable _admin;

/**
* @dev The proxy caller is the current admin, and can't fallback to the proxy target.
Expand Down