Skip to content

Use clones for testing non ERC1967 proxies #4371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Amxx merged 1 commit into from
Jun 20, 2023
Merged

Use clones for testing non ERC1967 proxies #4371

Amxx merged 1 commit into from
Jun 20, 2023

Conversation

@Amxx
Copy link
Collaborator

@Amxx Amxx commented Jun 19, 2023

IMO this makes the test clearer / easier to understand

PR Checklist

  • Tests

@Amxx Amxx added tests Test suite and helpers. ignore-changeset labels Jun 19, 2023
@Amxx Amxx requested review from ernestognw and frangio June 19, 2023 15:55
@changeset-bot
Copy link

changeset-bot bot commented Jun 19, 2023

⚠️ No Changeset found

Latest commit: b5d547b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

ernestognw
ernestognw approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Amxx Amxx merged commit 2271e2c into OpenZeppelin:master Jun 20, 2023
@Amxx Amxx deleted the test/use-clones-for-non-erc1967-proxies branch June 20, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ernestognw ernestognw ernestognw approved these changes

@frangio frangio Awaiting requested review from frangio

Assignees

No one assigned

Labels

ignore-changeset tests Test suite and helpers.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Amxx @ernestognw