Skip to content

Add Governor signature nonces #4378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Amxx merged 18 commits into from
Jul 3, 2023
Merged

Add Governor signature nonces #4378

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
0619b5c
Add Governor signature nonces
ernestognw Jun 22, 2023
5ecb405
Add changeset
ernestognw Jun 22, 2023
9e9e238
Ignore initcode-size warnings
ernestognw Jun 22, 2023
b84ea6e
Fix lint
ernestognw Jun 22, 2023
2781b5f
Apply suggestions
ernestognw Jun 23, 2023
ba44fa1
Improve testing coverage
ernestognw Jun 23, 2023
3f6e520
Update .changeset/sixty-numbers-reply.md
ernestognw Jun 29, 2023
79c5982
Do not emit Approval event when calling transferFrom (#4370)
Amxx Jun 22, 2023
35de382
Update comment to reflect code logic in Ownable.sol (#4369)
s-tikhomirov Jun 22, 2023
a75ca26
Pack Governor's ProposalCore into a single slot (#4268)
Amxx Jun 23, 2023
b32bfdd
Update Ownable2Step docs (#4384)
RenanSouza2 Jun 23, 2023
d518d65
Add unreleased disclaimer in readme
frangio Jun 24, 2023
71cd6ba
Rename `ERC1155InsufficientApprovalForAll` to `ERC1155MissingApproval…
ernestognw Jun 26, 2023
48a048c
Add Foundry installation instructions with required warnings (#4389)
frangio Jun 26, 2023
8a810c9
Add `ERC2771Forwarder` as an enhanced successor to `MinimalForwarder`…
ernestognw Jun 29, 2023
f808576
Fix details AccessControl-test (#4391)
RenanSouza2 Jun 29, 2023
2ed9be3
Fix tests
ernestognw Jun 29, 2023
2ae0a13
Merge branch 'master' into lib-895-add-governor-signature-nonces
Amxx Jun 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improve testing coverage
  • Loading branch information
@ernestognw
ernestognw committed Jun 23, 2023
commit ba44fa17e88989023967ad5df0faf0612d67b291
4 changes: 4 additions & 0 deletions test/governance/extensions/GovernorWithParams.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,8 @@ contract('GovernorWithParams', function (accounts) {
sig[69] ^= 0xff;
return sig;
},
reason: 'no particular reason',
params: encodedParams,
}),
'GovernorInvalidSigner',
[],
Expand All @@ -210,6 +212,8 @@ contract('GovernorWithParams', function (accounts) {
voter: this.voterBySig.address,
nonce: nonce.addn(1),
signature: this.signature,
reason: 'no particular reason',
params: encodedParams,
}),
// The signature check implies the nonce can't be tampered without changing the signer
'GovernorInvalidSigner',
Expand Down