Skip to content

Use explicit imports #4399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frangio merged 12 commits into from
Jun 29, 2023
Merged

Use explicit imports #4399

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
fd861a9
Use explicit imports
frangio Jun 28, 2023
5e583bf
add changeset
frangio Jun 29, 2023
05b74c6
update hardhat-exposed
frangio Jun 29, 2023
5fd4bdf
update patch
frangio Jun 29, 2023
7940c68
fix foundry tests
frangio Jun 29, 2023
15799c1
fix procedural generation
Amxx Jun 29, 2023
edaf2f4
Merge remote-tracking branch 'upstream/master' into explicit-imports
frangio Jun 29, 2023
79f7b9b
Add solhint rule for global imports
ernestognw Jun 29, 2023
5732401
Update doc examples
ernestognw Jun 29, 2023
aff850f
Fix incorrect doc imports
ernestognw Jun 29, 2023
ee89385
Fix upgradeable patch
ernestognw Jun 29, 2023
eeecdd1
Fix upgradeable patch again
ernestognw Jun 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix foundry tests
  • Loading branch information
@frangio
frangio committed Jun 29, 2023
commit 7940c6825084f70e57c1ab46b7aa5f278b9d35ad
3 changes: 2 additions & 1 deletion test/token/ERC721/extensions/ERC721Consecutive.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@ pragma solidity ^0.8.19;

// solhint-disable func-name-mixedcase

import {ERC721} from "../../../../contracts/token/ERC721/ERC721.sol";
import {ERC721Consecutive} from "../../../../contracts/token/ERC721/extensions/ERC721Consecutive.sol";
import {Test} from "forge-std/Test.sol";
import {Test, StdUtils} from "forge-std/Test.sol";

function toSingleton(address account) pure returns (address[] memory) {
address[] memory accounts = new address[](1);
Expand Down
2 changes: 1 addition & 1 deletion test/utils/ShortStrings.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ pragma solidity ^0.8.19;

import {Test} from "forge-std/Test.sol";

import {ShortStrings} from "../../contracts/utils/ShortStrings.sol";
import {ShortStrings, ShortString} from "../../contracts/utils/ShortStrings.sol";

contract ShortStringsTest is Test {
string _fallback;
Expand Down