Skip to content

Refactor ERC721 to use _update pattern #4419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
frangio wants to merge 8 commits into from
Closed

Refactor ERC721 to use _update pattern #4419

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2c9f7bb
Refactor ERC721 to use _update pattern
frangio Jul 4, 2023
930ee64
Update contracts/token/ERC721/ERC721.sol
frangio Jul 7, 2023
14ffe4d
Apply suggestions
ernestognw Jul 7, 2023
63717fc
Rename updateBalance to increaseBalance
ernestognw Jul 7, 2023
5f05fc9
Fix tests (omg hopefully)
ernestognw Jul 7, 2023
38c0bf0
Add changeset
ernestognw Jul 7, 2023
ca05bc5
Use _increaseBalance in _update
ernestognw Jul 7, 2023
cdacda1
Rollback _increaseBalance in _update
ernestognw Jul 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update contracts/token/ERC721/ERC721.sol 
Co-authored-by: Ernesto García <[email protected]>
  • Loading branch information
@frangio @ernestognw
frangio and ernestognw authored Jul 7, 2023
commit 930ee64d89cafabd273a5c591256c57a97c0f6e1
2 changes: 1 addition & 1 deletion contracts/token/ERC721/ERC721.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ abstract contract ERC721 is Context, ERC165, IERC721, IERC721Metadata, IERC721Er
*
* IMPORTANT: Any overrides to this function that add ownership of tokens not tracked by the
* core ERC721 logic MUST be matched with the use of {_updateBalance} to keep balances
* consistent with ownership. The invariant being that for any address `a` the value returned by
* consistent with ownership. The invariant to preserve is that for any address `a` the value returned by
* `balanceOf(a)` must be equal to the number of tokens such that `_ownerOf(tokenId)` is `a`.
*/
function _ownerOf(uint256 tokenId) internal view virtual returns (address) {
Expand Down