Skip to content

Remove "available since" comments #4424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Amxx merged 9 commits into from
Jul 6, 2023
Merged

Remove "available since" comments #4424

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f501541
Remove Available since comments
frangio Jul 5, 2023
7c823a4
update patch
frangio Jul 5, 2023
2aee47e
Update SafeCast.js
Amxx Jul 5, 2023
e4a73af
Update StorageSlot.js
Amxx Jul 5, 2023
b39bfd1
Update StorageSlot.js
Amxx Jul 5, 2023
c70e05f
Merge branch 'master' into remove-available-since
Amxx Jul 5, 2023
2a224d2
Merge branch 'master' into remove-available-since
frangio Jul 5, 2023
3a6d798
Merge branch 'remove-available-since' of https://github.com/frangio/o…
frangio Jul 5, 2023
128e06d
remove unused require
frangio Jul 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 0 additions & 56 deletions scripts/generate/templates/SafeCast.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,62 +4,6 @@ const { range } = require('../../helpers');

const LENGTHS = range(8, 256, 8).reverse(); // 248 → 8 (in steps of 8)

// Returns the version of OpenZeppelin Contracts in which a particular function was introduced.
// This is used in the docs for each function.
const version = (selector, length) => {
switch (selector) {
case 'toUint(uint)': {
switch (length) {
case 8:
case 16:
case 32:
case 64:
case 128:
return '2.5';
case 96:
case 224:
return '4.2';
default:
assert(LENGTHS.includes(length));
return '4.7';
}
}
case 'toInt(int)': {
switch (length) {
case 8:
case 16:
case 32:
case 64:
case 128:
return '3.1';
default:
assert(LENGTHS.includes(length));
return '4.7';
}
}
case 'toUint(int)': {
switch (length) {
case 256:
return '3.0';
default:
assert(false);
return;
}
}
case 'toInt(uint)': {
switch (length) {
case 256:
return '3.0';
default:
assert(false);
return;
}
}
default:
assert(false);
}
};

const header = `\
pragma solidity ^0.8.19;

Expand Down
14 changes: 7 additions & 7 deletions scripts/generate/templates/StorageSlot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
const format = require('../format-lines');
const { capitalize, unique } = require('../../helpers');
const { capitalize } = require('../../helpers');

const TYPES = [
{ type: 'address', isValueType: true, version: '4.1' },
{ type: 'bool', isValueType: true, name: 'Boolean', version: '4.1' },
{ type: 'bytes32', isValueType: true, version: '4.1' },
{ type: 'uint256', isValueType: true, version: '4.1' },
{ type: 'string', isValueType: false, version: '4.9' },
{ type: 'bytes', isValueType: false, version: '4.9' },
{ type: 'address', isValueType: true },
{ type: 'bool', isValueType: true, name: 'Boolean' },
{ type: 'bytes32', isValueType: true },
{ type: 'uint256', isValueType: true },
{ type: 'string', isValueType: false },
{ type: 'bytes', isValueType: false },
].map(type => Object.assign(type, { struct: (type.name ?? capitalize(type.type)) + 'Slot' }));

const header = `\
Expand Down