Skip to content

Move ECDSA message hash methods to its own MessageHashUtils library #4430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Amxx merged 9 commits into from
Jul 7, 2023
Merged

Move ECDSA message hash methods to its own MessageHashUtils library #4430

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4dad3d5
Move `ECDSA` message hash functions to its own `MessageHashUtils` lib…
ernestognw Jul 5, 2023
c2ddcd8
Add changeset
ernestognw Jul 5, 2023
491f622
Fix upgradeable patch conflicts
ernestognw Jul 6, 2023
b3e760f
Apply suggestions
ernestognw Jul 6, 2023
940e9ee
Merge branch 'master' into lib-904-move-some-eip712-functions-to-sepa…
ernestognw Jul 6, 2023
048fe76
Update upgradeable patch
ernestognw Jul 6, 2023
878f253
Update .changeset/hot-dingos-kiss.md
ernestognw Jul 6, 2023
f5a1c55
Update docs/modules/ROOT/pages/utilities.adoc
ernestognw Jul 6, 2023
d976a6f
Merge branch 'master' into lib-904-move-some-eip712-functions-to-sepa…
ernestognw Jul 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update docs/modules/ROOT/pages/utilities.adoc 
Co-authored-by: Francisco <[email protected]>
  • Loading branch information
@ernestognw @frangio
ernestognw and frangio authored Jul 6, 2023
commit f5a1c55a9b009ae5b90329879385f33a4e2f8a5b
2 changes: 1 addition & 1 deletion docs/modules/ROOT/pages/utilities.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ function _verify(bytes32 data, bytes memory signature, address account) internal
}
----

WARNING: Getting signature verification right is not trivial: make sure you fully read and understand xref:api:utils.adoc#MessageHashUtils[`MessageHashUtils`]'s and xref:api:utils.adoc#ECDSA[`ECDSA`]'s documentations.
WARNING: Getting signature verification right is not trivial: make sure you fully read and understand xref:api:utils.adoc#MessageHashUtils[`MessageHashUtils`]'s and xref:api:utils.adoc#ECDSA[`ECDSA`]'s documentation.

=== Verifying Merkle Proofs

Expand Down