Skip to content

Add GovernorTimelockControl address to TimelockController salt #4432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frangio merged 13 commits into from
Jul 12, 2023
Merged

Add GovernorTimelockControl address to TimelockController salt #4432

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
4a9a6aa
Add GovernorTimelockControl address to TimelockController salt
ernestognw Jul 6, 2023
00ff5e1
Add changeset
ernestognw Jul 6, 2023
b63d484
Merge branch 'master' into lib-834-use-governor-address-in-id-hash
ernestognw Jul 9, 2023
bcb0b84
Merge branch 'master' into lib-834-use-governor-address-in-id-hash
ernestognw Jul 12, 2023
fd0ef64
add logging
frangio Jul 12, 2023
5903861
remove only
frangio Jul 12, 2023
ce91062
add only
frangio Jul 12, 2023
29a1b1d
fix only
frangio Jul 12, 2023
4d21d32
remove only
frangio Jul 12, 2023
225c6ec
fix timelockSalt
frangio Jul 12, 2023
3563815
remove console.log
frangio Jul 12, 2023
e775b46
add period
frangio Jul 12, 2023
9dd7f39
Update .changeset/purple-cats-cheer.md
ernestognw Jul 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add logging
  • Loading branch information
@frangio
frangio committed Jul 12, 2023
commit fd0ef64303ef0a7c642f55edb020a1ef05428009
4 changes: 3 additions & 1 deletion test/governance/extensions/GovernorTimelockControl.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,14 +153,16 @@ contract('GovernorTimelockControl', function (accounts) {
});

describe('on execute', function () {
it('if not queued', async function () {
it.only('if not queued', async function () {
await this.helper.propose();
await this.helper.waitForSnapshot();
await this.helper.vote({ support: Enums.VoteType.For }, { from: voter1 });
await this.helper.waitForDeadline(+1);

expect(await this.mock.state(this.proposal.id)).to.be.bignumber.equal(Enums.ProposalState.Succeeded);

console.log(this.mock.address, this.proposal.shortProposal[3]);

await expectRevertCustomError(this.helper.execute(), 'TimelockUnexpectedOperationState', [
this.proposal.timelockid,
proposalStatesToBitMap(Enums.OperationState.Ready),
Expand Down