Skip to content

Allow Initializable versions greater than 256 #4460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frangio merged 13 commits into from
Aug 7, 2023
+77 −33
Merged

Allow Initializable versions greater than 256 #4460

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
8bcba2f
Allow reinitializers versions greater than 256
ernestognw Jul 14, 2023
6df8c25
Use uint64 instead
ernestognw Jul 14, 2023
2a6e2f6
Add changeset
ernestognw Jul 14, 2023
54395da
Simplify initializer
ernestognw Jul 15, 2023
eabc9c0
Improve gas (?)
ernestognw Jul 18, 2023
9777b62
Improved function docs
ernestognw Jul 20, 2023
aa0bb6f
Revert #3950 fix
ernestognw Jul 27, 2023
bae9786
Merge branch 'master' into lib-828-reinitializers-versions-greater-th…
ernestognw Jul 27, 2023
1b27b49
Fix conflict
ernestognw Jul 28, 2023
f106f03
Use 0xFFFFFFFFFFFFFFFF in tests
ernestognw Jul 30, 2023
eb76991
Use 2n ** 64n - 1n in tests
ernestognw Jul 31, 2023
4d6d205
Used web3.utils.toBN for tests
ernestognw Aug 2, 2023
5935090
Update .changeset/thick-pumpkins-exercise.md
ernestognw Aug 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix conflict
  • Loading branch information
@ernestognw
ernestognw committed Jul 28, 2023
commit 1b27b496ab8bc58050d63f13c45fd8648924ee4f
4 changes: 3 additions & 1 deletion contracts/proxy/utils/Initializable.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,9 @@ abstract contract Initializable {
* @dev Reverts if the contract is not in an initializing state. See {onlyInitializing}.
*/
function _checkInitializing() internal view virtual {
if (!_initializing) revert NotInitializing();
if (!_isInitializing()) {
revert NotInitializing();
}
}

/**
Expand Down