Skip to content

Add internal functions inside modifiers #4472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frangio merged 9 commits into from
Jul 26, 2023
Merged

Add internal functions inside modifiers #4472

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
30920e8
Replace the onlyGovernance code with an internal function called _che…
allwin199 Jul 21, 2023
8de0e9f
Replace the onlyProxy code with an internal function called _checkPro…
allwin199 Jul 21, 2023
8daef38
Replace the onlyInitializing code with an internal function called _c…
allwin199 Jul 21, 2023
8ae3e19
Update comments in contracts/governance/Governor.sol
allwin199 Jul 26, 2023
573967c
Update comments in contracts/proxy/utils/Initializable.sol
allwin199 Jul 26, 2023
d5b95f2
Update comments in contracts/proxy/utils/UUPSUpgradeable.sol
allwin199 Jul 26, 2023
116d7d7
Update comments in contracts/proxy/utils/UUPSUpgradeable.sol
allwin199 Jul 26, 2023
c454c86
add changeset
Amxx Jul 26, 2023
e7bf564
Update swift-numbers-cry.md
frangio Jul 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update comments in contracts/proxy/utils/UUPSUpgradeable.sol 
Co-authored-by: Ernesto García <[email protected]>
  • Loading branch information
@allwin199 @ernestognw
allwin199 and ernestognw authored Jul 26, 2023
commit d5b95f24e581c46b7996060e6038ad0f471ad353
5 changes: 3 additions & 2 deletions contracts/proxy/utils/UUPSUpgradeable.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,9 @@ abstract contract UUPSUpgradeable is IERC1822Proxiable {
}

/**
* @dev Throws if the execution is not being performed through a delegatecall call
* Throws if not called through an active proxy
* @dev Reverts if the execution is not performed via delegatecall or the execution
* context is not of a proxy with an ERC1967-compliant implementation pointing to self.
* See {_onlyProxy}.
*/
function _checkProxy() internal view virtual {
if (
Expand Down