Skip to content

Make ERC2771Context return original sender address if msg.data.length <= 20 #4481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Amxx merged 9 commits into from
Jul 25, 2023
Merged

Make ERC2771Context return original sender address if msg.data.length <= 20 #4481

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
239bb13
Make ERC2771Context return original sender address if `msg.data.lengt…
ernestognw Jul 25, 2023
ae34a9c
Lint
ernestognw Jul 25, 2023
f133d09
Add Changeset
ernestognw Jul 25, 2023
9dc1331
Adjust changeset
ernestognw Jul 25, 2023
fb35cf6
Update .changeset/unlucky-beans-obey.md
ernestognw Jul 25, 2023
1d035e2
Update test/metatx/ERC2771Context.test.js
ernestognw Jul 25, 2023
dd1ef0c
Update unlucky-beans-obey.md
Amxx Jul 25, 2023
51c190c
Update unlucky-beans-obey.md
Amxx Jul 25, 2023
f056ce5
Update .changeset/unlucky-beans-obey.md
ernestognw Jul 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Lint
  • Loading branch information
@ernestognw
ernestognw committed Jul 25, 2023
commit ae34a9cf041a83fe183831d84c6987dc5b4eb1c3
6 changes: 3 additions & 3 deletions test/metatx/ERC2771Context.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,13 +81,13 @@ contract('ERC2771Context', function (accounts) {
const { tx } = await this.forwarder.execute(req);
await expectEvent.inTransaction(tx, ERC2771ContextMock, 'Sender', { sender: this.sender });
});

it('returns the original sender when calldata length is less than 20 bytes (address length)', async function () {
// The forwarder doesn't produce calls with calldata length less than 20 bytes
const recipient = await ERC2771ContextMock.new(anotherAccount);

const { tx } = await recipient.msgSender({ from: anotherAccount });

await expectEvent.inTransaction(tx, ERC2771ContextMock, 'Sender', { sender: anotherAccount });
});
});
Expand Down