Skip to content

Implement recommendations from 5.0 audit Phase 1B #4502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frangio merged 26 commits into from
Aug 4, 2023
Merged

Implement recommendations from 5.0 audit Phase 1B #4502

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
a06b352
Fix M-05
ernestognw Aug 2, 2023
316c30c
Fix M-07
ernestognw Aug 2, 2023
351565f
Fix L-02
ernestognw Aug 2, 2023
1bd3544
Fix L-03
ernestognw Aug 2, 2023
53b4feb
Fix L-04
ernestognw Aug 2, 2023
a94adcd
Fix L-08
ernestognw Aug 2, 2023
9afa6c9
Fix L-09
ernestognw Aug 2, 2023
5a0e133
Fix CR-01
ernestognw Aug 2, 2023
58546a1
Fix N-22
ernestognw Aug 2, 2023
1164c51
Fix N-21
ernestognw Aug 2, 2023
dee9963
Fix N-20
ernestognw Aug 2, 2023
687b805
Fix N-17
ernestognw Aug 2, 2023
60329ea
Fix N-19
ernestognw Aug 2, 2023
ffd9520
Update contracts/proxy/utils/UUPSUpgradeable.sol
Amxx Aug 2, 2023
c2e835e
Fix R-04
ernestognw Aug 2, 2023
7263524
Fix N-14
ernestognw Aug 3, 2023
6689060
Fix N-16
ernestognw Aug 3, 2023
11213f5
Fix L-03-2
ernestognw Aug 4, 2023
29fd3ea
Fix L-10
ernestognw Aug 4, 2023
889c112
minimize assembly in _isTrustedByTraget
frangio Aug 4, 2023
13cdb42
add changeset for VestingWallet
frangio Aug 4, 2023
745b14d
merge if statements
frangio Aug 4, 2023
3d8baba
swap if statements for consistency
frangio Aug 4, 2023
ceb19fd
Revert "Fix L-10"
frangio Aug 4, 2023
f9904fa
Apply suggestions from code review
frangio Aug 4, 2023
8cb5200
remove whitespace
frangio Aug 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix N-22
  • Loading branch information
@ernestognw
ernestognw committed Aug 2, 2023
commit 58546a17c4e78aedf55aa3ae49e81d421bdca4a6
2 changes: 1 addition & 1 deletion contracts/proxy/ERC1967/ERC1967Proxy.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ contract ERC1967Proxy is Proxy {
* https://eth.wiki/json-rpc/API#eth_getstorageat[`eth_getStorageAt`] RPC call.
* `0x360894a13ba1a3210667c828492db98dca3e2076cc3735a920a3ca505d382bbc`
*/
function _implementation() internal view virtual override returns (address impl) {
function _implementation() internal view virtual override returns (address) {
return ERC1967Utils.getImplementation();
}
}