Skip to content

Use Ownable in VestingWallet instead of an immutable beneficiary #4508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frangio merged 10 commits into from
Aug 4, 2023
Merged

Use Ownable in VestingWallet instead of an immutable beneficiary #4508

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
21e01e7
Use Ownable2Step in VestingWallet with restricted `release()`
ernestognw Aug 4, 2023
9059ff1
Fix Create2 tests
ernestognw Aug 4, 2023
f73699b
Actually fix tests
ernestognw Aug 4, 2023
42a454e
use Ownable instead of Ownable2Step and remove onlyOwner
frangio Aug 4, 2023
4f56d4d
add docs about transferability
frangio Aug 4, 2023
085aaf6
revert test changes
frangio Aug 4, 2023
21bc8b4
revert Create2 test
frangio Aug 4, 2023
ecd30f6
adjust changeset
frangio Aug 4, 2023
c70b8d0
Merge branch 'master' into fix/1b-m-06
frangio Aug 4, 2023
4ce8164
Update contracts/finance/VestingWallet.sol
ernestognw Aug 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
revert Create2 test
  • Loading branch information
@frangio
frangio committed Aug 4, 2023
commit 21bc8b4ff4ccceca2aa105fa94f644da0ccd4e17
3 changes: 0 additions & 3 deletions test/utils/Create2.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,6 @@ contract('Create2', function (accounts) {

const instance = await VestingWallet.at(offChainComputed);

// Needs to be accepted
await instance.acceptOwnership({ from: other });

expect(await instance.owner()).to.be.equal(other);
});

Expand Down