Skip to content

Move beneficiary zero address check to Ownable #4531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frangio merged 9 commits into from
Sep 4, 2023
Merged

Move beneficiary zero address check to Ownable #4531

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a55eac5
moved beneficiary zero address check to Ownable
NishantKoyalwar Aug 17, 2023
eeb6ec2
formatted code using prettier
NishantKoyalwar Aug 17, 2023
72b508c
Remove unused error
Amxx Aug 25, 2023
e03cfa9
added changeset
NishantKoyalwar Aug 31, 2023
861be75
Merge remote-tracking branch 'origin'
NishantKoyalwar Aug 31, 2023
1d111c8
Update .changeset/clever-bats-kick.md
NishantKoyalwar Aug 31, 2023
e37d5b4
update tests
Amxx Sep 1, 2023
67d1a7c
lint
frangio Sep 4, 2023
edf487a
Update clever-bats-kick.md
frangio Sep 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint
  • Loading branch information
@frangio
frangio authored Sep 4, 2023
commit 67d1a7c5ccc9365078c0dcd8a9962d3924f93b9e
6 changes: 1 addition & 5 deletions test/access/Ownable.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,7 @@ contract('Ownable', function (accounts) {
});

it('rejects zero address for initialOwner', async function () {
await expectRevertCustomError(
Ownable.new(constants.ZERO_ADDRESS),
'OwnableInvalidOwner',
[constants.ZERO_ADDRESS],
);
await expectRevertCustomError(Ownable.new(constants.ZERO_ADDRESS), 'OwnableInvalidOwner', [constants.ZERO_ADDRESS]);
});

it('has an owner', async function () {
Expand Down