Skip to content

Use namespaced storage for upgradeable contracts #4534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frangio merged 13 commits into from
Sep 11, 2023
Merged

Use namespaced storage for upgradeable contracts #4534

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b42ae69
add unsafe-allow immutable
frangio Aug 16, 2023
fe22a59
reorder variables
frangio Aug 16, 2023
a03357d
add namespace flags to transpile.sh
frangio Aug 19, 2023
6058cb2
update solidity-ast
frangio Aug 19, 2023
ca3f267
Revert "add unsafe-allow immutable"
frangio Aug 19, 2023
68dadf7
use transpiler prerelease
frangio Aug 19, 2023
5e0b1a2
Revert "reorder variables"
frangio Aug 19, 2023
f79775e
add exceptions for GovernorVotes
frangio Aug 19, 2023
fce457c
remove public immutable variable
frangio Aug 19, 2023
d47d450
use named return variable to avoid stack too deep
frangio Aug 19, 2023
31501a5
bump node version
frangio Aug 19, 2023
d2be2b8
add changeset
frangio Aug 19, 2023
8972612
switch to latest
frangio Aug 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use named return variable to avoid stack too deep
  • Loading branch information
@frangio
frangio committed Aug 19, 2023
commit d47d450a67ba29a42c65d4315973c0bcd2e32e51
6 changes: 3 additions & 3 deletions contracts/governance/Governor.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,8 +299,8 @@ abstract contract Governor is Context, ERC165, EIP712, Nonces, IGovernor, IERC72
bytes[] memory calldatas,
string memory description,
address proposer
) internal virtual returns (uint256) {
uint256 proposalId = hashProposal(targets, values, calldatas, keccak256(bytes(description)));
) internal virtual returns (uint256 proposalId) {
proposalId = hashProposal(targets, values, calldatas, keccak256(bytes(description)));

if (targets.length != values.length || targets.length != calldatas.length || targets.length == 0) {
revert GovernorInvalidProposalLength(targets.length, calldatas.length, values.length);
Expand Down Expand Up @@ -329,7 +329,7 @@ abstract contract Governor is Context, ERC165, EIP712, Nonces, IGovernor, IERC72
description
);

return proposalId;
// Using a named return variable to avoid stack too deep errors
}

/**
Expand Down