Explicit public visibility on methods #456
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frangio
reviewed
Sep 18, 2017
contracts/token/TokenTimelock.sol
Outdated
| * @notice Transfers tokens held by timelock to beneficiary. | ||
| */ | ||
| function release() { | ||
| function release() public constant { |
Contributor
There was a problem hiding this comment.
These are not constant functions, can you please fix it?
Contributor
|
Awesome, thanks @dmx374! I rebased and merged manually (b395b06). |
This was referenced Sep 18, 2017
Merged
Contributor
|
if we take into account the solidity style-guideline (http://solidity.readthedocs.io/en/develop/style-guide.html#function-declaration) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.