Skip to content

Improve Initializable readability using intermediate variables #4576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frangio merged 4 commits into from
Sep 5, 2023
Merged

Improve Initializable readability using intermediate variables #4576

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b7de50c
Improve Initializable readability using intermediate variables
Amxx Sep 5, 2023
9249a0b
Update lazy-rice-joke.md
frangio Sep 5, 2023
329dc22
Update contracts/proxy/utils/Initializable.sol
Amxx Sep 5, 2023
175b1e9
Update contracts/proxy/utils/Initializable.sol
Amxx Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update contracts/proxy/utils/Initializable.sol 
Co-authored-by: Francisco <[email protected]>
  • Loading branch information
@Amxx @frangio
Amxx and frangio authored Sep 5, 2023
commit 329dc22bafc36c701ada65d00555ae4772e69d94
10 changes: 5 additions & 5 deletions contracts/proxy/utils/Initializable.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,11 +108,11 @@ abstract contract Initializable {
bool isTopLevelCall = !$._initializing;
uint64 initialized = $._initialized;

// Are allowed:
// - "initialSetup" calls: the contract is not in the initializing state and no previous version was
// initialized
// - "construction" calls: the contract is already initialized at step 1 (no reininitialization) and the
// current contract is not yet constructed.
// Allowed calls:
// - initialSetup: the contract is not in the initializing state and no previous version was
// initialized
// - construction: the contract is initialized at version 1 (no reininitialization) and the
// current contract is just being deployed
bool initialSetup = initialized == 0 && isTopLevelCall;
bool construction = initialized == 1 && address(this).code.length == 0;

Expand Down