Skip to content

Add explicit visibility #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maraoz merged 1 commit into from
Sep 22, 2017
Merged

Add explicit visibility #460

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add explicit visibility
  • Loading branch information
Jack Bauer authored Sep 19, 2017
commit 3733c069c959fe9e6c069abae98900d16b921928
8 changes: 3 additions & 5 deletions contracts/token/StandardToken.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import './ERC20.sol';
*/
contract StandardToken is ERC20, BasicToken {

mapping (address => mapping (address => uint256)) allowed;
mapping (address => mapping (address => uint256)) internal allowed;


/**
Expand Down Expand Up @@ -70,15 +70,13 @@ contract StandardToken is ERC20, BasicToken {
* the first transaction is mined)
* From MonolithDAO Token.sol
*/
function increaseApproval (address _spender, uint _addedValue)
returns (bool success) {
function increaseApproval (address _spender, uint _addedValue) public returns (bool success) {
allowed[msg.sender][_spender] = allowed[msg.sender][_spender].add(_addedValue);
Approval(msg.sender, _spender, allowed[msg.sender][_spender]);
return true;
}

function decreaseApproval (address _spender, uint _subtractedValue)
returns (bool success) {
function decreaseApproval (address _spender, uint _subtractedValue) public returns (bool success) {
uint oldValue = allowed[msg.sender][_spender];
if (_subtractedValue > oldValue) {
allowed[msg.sender][_spender] = 0;
Expand Down