-
Notifications
You must be signed in to change notification settings - Fork 12.4k
Improve AccessManager tests #4613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
63 commits
Select commit
Hold shift + click to select a range
1c79698
Improve docs
ernestognw 0218e2c
Make role's admin role more specific
ernestognw 7f3c162
First pass through tests
ernestognw d27cbdc
Add _canCallSelf
ernestognw 327a5b5
Merge branch 'audit/wip/2a-2b' into access-manager/tests
ernestognw febdf2a
AccessManager _canCallSelf and _canCallExecuting
ernestognw acfc3aa
AccessManager _canCallSelf and _canCallExecuting
ernestognw 64a1c6e
Codespell
ernestognw 4a8920e
Merge branch 'audit/wip/2a-2b' into access-manager/coverage-review
ernestognw 62ff89b
Testing preview
ernestognw 1152dbb
Merge branch 'master' into access-manager/tests
ernestognw d4c6480
Checkpoint
ernestognw 6adcbf3
Finish role admin functions
ernestognw 9d601a7
Checkpoint
ernestognw e2190d6
Checkpoint
ernestognw 4c08a9d
Removed on:
ernestognw 1d118eb
Define common admin ops path
ernestognw 778ac91
Checkpoint
ernestognw 3aeb3c8
Checkpoint
ernestognw 61eea90
Update contracts/access/manager/AccessManager.sol
ernestognw ba8b3ca
Remove .call(this)
ernestognw 8e3583b
Improve test names
ernestognw dce308e
Improve test names
ernestognw d0b3824
Checkpoint
ernestognw 3a216f7
Finish execute
ernestognw fb0374f
Finish AccessManager tests
ernestognw 856aa0c
Make selector decoding consistent
ernestognw 242b19e
Merge branch 'master' into access-manager/tests
ernestognw d8dfe3b
Fix codespell
ernestognw 1b66afe
Cherry pick from #4624
ernestognw 3112045
Revert _setGrantDelay PUBLIC_ROLE case
ernestognw 51e499b
Revert canCall hasRole path return
ernestognw 47995ef
Update contracts/access/manager/AccessManager.sol
ernestognw e9cc80c
Update contracts/access/manager/AccessManager.sol
ernestognw bd4ab08
Update contracts/access/manager/AccessManager.sol
ernestognw a870c6b
Update contracts/access/manager/IAccessManager.sol
ernestognw d4dafda
Update test/access/manager/AccessManager.test.js
ernestognw 04c5a9b
Implement suggestion for writing the _consumingSchedule variable
ernestognw 9c0b8ad
Update test/helpers/access-manager.js
ernestognw 854fbfe
Lint
ernestognw 91cea51
Update contracts/access/manager/AccessManager.sol
ernestognw efce54a
Update contracts/access/manager/AccessManager.sol
ernestognw e955172
Update contracts/utils/types/Time.sol
ernestognw c0e69ee
Lint
ernestognw ea0973a
Recovered 100% tests coverage
ernestognw ee5315a
Remove console
ernestognw 172b11f
Fix .only
ernestognw 42e8a1a
execute+schedule tweaks
frangio 180ef6c
fix tests
frangio 9edb313
refactor
frangio 7cb374d
trigger ci
frangio 41b6880
Merge branch 'master' into access-manager/tests
ernestognw 58e9545
Merge branch 'master' into access-manager/tests
frangio 9d493af
fix upgradeable tests
frangio 9291007
replace syntax `foo: function () {` -> `foo() {
frangio 2ab4382
replace syntax (continued)
frangio eb914a2
lint
frangio da3d343
Fix consumingScheduleOp
ernestognw 033337b
Fix consumeScheduleOp again
ernestognw a1011be
Apply review suggestions
ernestognw 74009db
Check also for AccessManagedUpgradeable artifact
ernestognw 1f4e7ca
Lint
ernestognw 6e397cc
Merge branch 'master' into access-manager/tests
ernestognw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.