-
Notifications
You must be signed in to change notification settings - Fork 12.4k
Enable partial transpilation for upgradeable package #4628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
0f54291
enable partial transpilation
frangio b4a9a76
refactor prepare/prepack scripts
frangio f648bfe
add vanilla as dependency during upgradeable tests
frangio 3910fbc
fix npm pack output
frangio 270c006
fix npm pack
frangio df08dd7
fix transpile command
frangio 59746e6
change approach without using pack
frangio e904e02
fix workflow
frangio 0f2bafe
fix checkout location
frangio 8002e8d
fix run
frangio 9e2dcf1
fix mkdir
frangio 0ff2901
fix ln
frangio 5d8422f
add transpiler as dependency]
frangio de7a277
update hardhat-exposed
frangio 63acb32
update transpiler
frangio 5f0c801
enable exposed imports
frangio b6476c1
fix config
frangio 448d8f6
add Stateless.sol
frangio 0f7c3e2
fix stateless
frangio 7246dbb
add dummy contract in stateless file
frangio ef88118
add all library imports
frangio 01a768b
update hardhat-exposed
frangio e16c0ae
mark some contracts as stateless
Amxx 9dc5442
sort
Amxx 4771215
Add peer dependency to package.json
Amxx 4ca92e2
fix import path
Amxx b320373
cleanup
Amxx 268e17f
mark UUPSUpgradeable as stateless
Amxx 781d5f2
Merge branch 'master' into partial-transpilation
frangio 242b716
add changeset
frangio 8d8030b
Update .github/workflows/checks.yml
frangio f63cf2d
simplify prepack
frangio 86ebb2e
fix order of transpilation
frangio 9e1ce8d
Merge branch 'master' into partial-transpilation
frangio b51a866
fix location where peer dependency is added
frangio 5336454
read package version from contracts/package.json
Amxx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
refactor prepare/prepack scripts
- Loading branch information
commit b4a9a76318ca6651ea2957cef8941e6670549d3f
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,5 +15,3 @@ runs: | |
| run: npm ci | ||
| shell: bash | ||
| if: steps.cache.outputs.cache-hit != 'true' | ||
| env: | ||
| SKIP_COMPILE: true | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure the build are getting in ?
The line above only gets solidity files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, the entier "files" section of this package.json is probably useless
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the root package.json, that we don't publish any more. This
"files"field probably doesn't matter but I preferred keeping it and just removing the directory that will no longer be there.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My reasoning is that there may be some workflow that relies on
npm packat the root, I don't know.