Skip to content

Add Base64Url encoding #4822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ernestognw merged 17 commits into from
Jan 16, 2024
Merged

Add Base64Url encoding #4822

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
ffcc360
add encode url to the Base64 library
Amxx Jan 8, 2024
c3ef73a
add changeset
Amxx Jan 8, 2024
b217af3
refactor base64 encoding
Amxx Jan 10, 2024
ea29b55
typo
Amxx Jan 10, 2024
551ad07
cleanup
Amxx Jan 10, 2024
fb5dade
Apply suggestions from code review
Amxx Jan 10, 2024
6e3d973
fix tests
Amxx Jan 10, 2024
1f1ad9e
fix lint
Amxx Jan 10, 2024
edcdf5b
stable lint
Amxx Jan 10, 2024
b9e47dc
Add fuzzing tests
ernestognw Jan 10, 2024
ea6d5bb
Enable ffi
ernestognw Jan 10, 2024
66305d9
Change test name lol
ernestognw Jan 10, 2024
6a86d82
Avoid running Base64 fuzzing in CI
ernestognw Jan 11, 2024
7cfe507
Improve Base64 unit tests
ernestognw Jan 11, 2024
4b30a0b
Merge branch 'master' into feature/base64url
ernestognw Jan 12, 2024
26658ce
Merge branch 'master' into feature/base64url
ernestognw Jan 12, 2024
c05a170
Merge branch 'master' into feature/base64url
ernestognw Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Enable ffi
  • Loading branch information
@ernestognw
ernestognw committed Jan 10, 2024
commit ea6d5bbc45349c93c881e9b518899322489914c0
2 changes: 1 addition & 1 deletion .github/workflows/checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ jobs:
- name: Set up environment
uses: ./.github/actions/setup
- name: Run tests
run: forge test -vv
run: forge test -vv --ffi
Copy link
Collaborator Author

@Amxx Amxx Jan 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: We agreed to not include that in the package. The foundry tests will be disabled in CI (until base64 eventually becomes foundray-native)


coverage:
runs-on: ubuntu-latest
Expand Down