Skip to content

Bound lookup in arrays with duplicate #4842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Amxx merged 13 commits into from
Jan 29, 2024
Merged

Bound lookup in arrays with duplicate #4842

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d78ae17
Migrate 'arrays'
RenanSouza2 Nov 12, 2023
52b3bd8
fix findUpperBound and add findLowerBound
Amxx Nov 17, 2023
9a1411b
add memory variants
Amxx Nov 20, 2023
c4726c8
Merge branch 'master' into feature/array-bound-with-duplicates
Amxx Jan 18, 2024
a6ec616
fix merge
Amxx Jan 18, 2024
23e8db9
fix lint
Amxx Jan 18, 2024
c72591f
minimize change
Amxx Jan 18, 2024
9162e42
add changeset
Amxx Jan 18, 2024
ed1de5b
Apply suggestions from code review
Amxx Jan 18, 2024
3b10420
Update Arrays.test.js
Amxx Jan 24, 2024
e50630c
Merge branch 'master' into feature/array-bound-with-duplicates
Amxx Jan 28, 2024
39a9f7e
Apply PR suggestions
ernestognw Jan 29, 2024
7c9f21b
Lint
ernestognw Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix lint
  • Loading branch information
@Amxx
Amxx committed Jan 18, 2024
commit 23e8db94e39d59dcba76d39373b8d8c284a62b73
2 changes: 1 addition & 1 deletion test/utils/structs/Checkpoints.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ describe('Checkpoints', function () {
it('returns latest value', async function () {
const latest = this.checkpoints.at(-1);
expect(await this.methods.latest()).to.equal(latest.value);
expect(await this.methods.latestCheckpoint()).to.deep.equal([ true, latest.key, latest.value ]);
expect(await this.methods.latestCheckpoint()).to.deep.equal([true, latest.key, latest.value]);
});

it('cannot push values in the past', async function () {
Expand Down