Skip to content

Improve ERC-1363 documentation #4854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Amxx merged 3 commits into from
Jan 24, 2024
+7 −7
Merged

Improve ERC-1363 documentation #4854

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fae9d1e
improve erc1363 doc
Amxx Jan 24, 2024
c80f447
up
Amxx Jan 24, 2024
e84333f
Apply suggestions from code review
ernestognw Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
up
  • Loading branch information
@Amxx
Amxx committed Jan 24, 2024
commit c80f447f9ac618f2222f13e4ea196750fd218fe8
10 changes: 5 additions & 5 deletions contracts/token/ERC20/extensions/ERC1363.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ abstract contract ERC1363 is ERC20, ERC165, IERC1363 {
* Requirements:
*
* - The target has code (i.e. is a contract).
* - The target `to` must implement {IERC1363Receiver-onTransferReceived}.
* - The target `to` must implement the {IERC1363Receiver} interface.
* - The target must return the {IERC1363Receiver-onTransferReceived} selector to accept the transfer.
* - The internal {transfer} must succeed (returned `true`).
*/
Expand All @@ -84,7 +84,7 @@ abstract contract ERC1363 is ERC20, ERC165, IERC1363 {
* Requirements:
*
* - The target has code (i.e. is a contract).
* - The target `to` must implement {IERC1363Receiver-onTransferReceived}.
* - The target `to` must implement the {IERC1363Receiver} interface.
* - The target must return the {IERC1363Receiver-onTransferReceived} selector to accept the transfer.
* - The internal {transferFrom} must succeed (returned `true`).
*/
Expand Down Expand Up @@ -116,7 +116,7 @@ abstract contract ERC1363 is ERC20, ERC165, IERC1363 {
* Requirements:
*
* - The target has code (i.e. is a contract).
* - The target `to` must implement {IERC1363Spender-onApprovalReceived}.
* - The target `to` must implement the {IERC1363Spender} interface.
* - The target must return the {IERC1363Spender-onApprovalReceived} selector to accept the approval.
* - The internal {approve} must succeed (returned `true`).
*/
Expand All @@ -143,7 +143,7 @@ abstract contract ERC1363 is ERC20, ERC165, IERC1363 {
*
* - The target has code (i.e. is a contract).
* - The target `to` must implement the {IERC1363Receiver} interface.
* - The target should return the {IERC1363Receiver} interface id.
* - The target must return the {IERC1363Receiver-onTransferReceived} selector to accept the transfer.
*/
function _checkOnTransferReceived(address from, address to, uint256 value, bytes memory data) private {
if (to.code.length == 0) {
Expand Down Expand Up @@ -173,7 +173,7 @@ abstract contract ERC1363 is ERC20, ERC165, IERC1363 {
*
* - The target has code (i.e. is a contract).
* - The target `to` must implement the {IERC1363Spender} interface.
* - The target should return the {IERC1363Spender} interface id.
* - The target must return the {IERC1363Spender-onApprovalReceived} selector to accept the approval.
*/
function _checkOnApprovalReceived(address spender, uint256 value, bytes memory data) private {
if (spender.code.length == 0) {
Expand Down