Skip to content

Procedurally generate Arrays.sol #4859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ernestognw merged 14 commits into from
Mar 27, 2024
Merged

Procedurally generate Arrays.sol #4859

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
1fc91f1
Generate array.sol
RenanSouza2 Jan 28, 2024
414545a
include tests
RenanSouza2 Jan 28, 2024
8ddaa94
Refactor testd
RenanSouza2 Jan 28, 2024
8b60a5c
refactor fixture
RenanSouza2 Jan 28, 2024
b06b970
rename file
RenanSouza2 Jan 29, 2024
0bd6b7f
remove .only
RenanSouza2 Jan 29, 2024
4eeacc6
Merge master
ernestognw Mar 26, 2024
a9b199a
Merge branch 'master' into generate-arrays
ernestognw Mar 26, 2024
e826f70
Generate missing functions and simplify tests
ernestognw Mar 26, 2024
67aec22
Split sort helpers
ernestognw Mar 26, 2024
e9915db
Remove unnecessary casting
ernestognw Mar 26, 2024
0d65264
Remove unnecessary mocked function
ernestognw Mar 26, 2024
d16a0ed
update template to minimize generated code changes
Amxx Mar 26, 2024
c6c3bb9
reorder generated code
Amxx Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rename file
  • Loading branch information
@RenanSouza2
RenanSouza2 committed Jan 29, 2024
commit b06b97003e519b030b8c52e1c7e35384efd2eaee
2 changes: 1 addition & 1 deletion scripts/generate/templates/Arrays.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
const format = require('../format-lines');
const { capitalize } = require('../../helpers');
const { TYPES_STORAGE, TYPES_MEMORY } = require('./Array.opts');
const { TYPES_STORAGE, TYPES_MEMORY } = require('./Arrays.opts');

const header = `\
pragma solidity ^0.8.20;
Expand Down
0 scripts/generate/templates/Array.opts.js → scripts/generate/templates/Arrays.opts.js
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions test/utils/Arrays.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ const { loadFixture } = require('@nomicfoundation/hardhat-network-helpers');

const { randomArray, generators } = require('../helpers/random');
const { capitalize } = require('../../scripts/helpers');
const { TYPES_STORAGE, TYPES_MEMORY } = require('../../scripts/generate/templates/Array.opts');
const { TYPES_STORAGE, TYPES_MEMORY } = require('../../scripts/generate/templates/Arrays.opts');

// See https://en.cppreference.com/w/cpp/algorithm/ranges/lower_bound
const lowerBound = (array, value) => {
Expand All @@ -20,7 +20,7 @@ const lowerBound = (array, value) => {

const hasDuplicates = array => array.some((v, i) => array.indexOf(v) != i);

describe('Arrays', function () {
describe.only('Arrays', function () {
describe('findUpperBound', function () {
for (const [title, { array, tests }] of Object.entries({
'Even number of elements': {
Expand Down