Skip to content

Implement P256 verification via RIP-7212 precompile with Solidity fallback #4881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Amxx merged 82 commits into from
Jul 3, 2024
Merged

Implement P256 verification via RIP-7212 precompile with Solidity fallback #4881

Changes from 1 commit
Commits
Show all changes
82 commits
Select commit Hold shift + click to select a range
5e82076
Add P256 implementation and testing
Amxx Feb 7, 2024
da0f27e
enable optimizations by default
Amxx Feb 7, 2024
aa59c67
test recovering address
Amxx Feb 7, 2024
9512947
improved testing
Amxx Feb 7, 2024
a60bf48
spelling
Amxx Feb 7, 2024
9185026
fix lint
Amxx Feb 7, 2024
025e360
expose imports tick
Amxx Feb 7, 2024
803e735
fix lint
Amxx Feb 7, 2024
57fcecd
fix lint
Amxx Feb 7, 2024
4dae298
add changeset
Amxx Feb 7, 2024
6cf039d
improve doc
Amxx Feb 7, 2024
c094fa1
add envvar to force allowUnlimitedContractSize
Amxx Feb 7, 2024
20a03df
fix lint
Amxx Feb 7, 2024
15f1a6b
fix stack too deep error in coverage
Amxx Feb 7, 2024
e2040e4
reoder arguments to match ecrecover and EIP-7212
Amxx Feb 13, 2024
695b732
reduce diff
Amxx Mar 13, 2024
41aaf71
Merge branch 'master' into feature/P256
Amxx Mar 13, 2024
3bf4557
Update contracts/utils/cryptography/P256.sol
Amxx Apr 24, 2024
3cbf426
Merge branch 'master' into feature/P256
Amxx Apr 25, 2024
bba7fa3
update pseudocode reference
Amxx Apr 25, 2024
2812ed8
Update contracts/utils/cryptography/P256.sol
Amxx Apr 25, 2024
e0ef63b
refactor neutral element in jAdd
Amxx Apr 26, 2024
61a244d
add EIP-7212 support
Amxx May 17, 2024
910bc71
Merge branch 'master' into feature/P256
Amxx Jun 12, 2024
2e9d04d
Apply PR suggestions
ernestognw Jun 14, 2024
9062633
move invModPrime to Math.sol
Amxx Jun 17, 2024
a44bb71
update
Amxx Jun 17, 2024
3a6e1f5
update
Amxx Jun 17, 2024
3e71fad
codespell
Amxx Jun 17, 2024
887272b
test signature maleability
Amxx Jun 17, 2024
433548f
Iterate
ernestognw Jun 20, 2024
4f80ca0
Add more comments
ernestognw Jun 21, 2024
be69f5c
remove P256 public key to address derivation
Amxx Jun 21, 2024
fcde23f
Move publicKey from privateKey derivation function to tests
ernestognw Jun 21, 2024
5828566
Remove unnecessary test
ernestognw Jun 21, 2024
9362936
add wycheproof test
cairoeth Jun 21, 2024
921745b
Readd malleability check and rename
ernestognw Jun 22, 2024
2c113f4
Change arguments to bytes32
ernestognw Jun 22, 2024
fb7dc6f
remove unused malleable version
Amxx Jun 24, 2024
f264dae
Update contracts/utils/cryptography/P256.sol
Amxx Jun 24, 2024
2c9a137
Update contracts/utils/cryptography/P256.sol
Amxx Jun 24, 2024
f4cbf51
up
Amxx Jun 24, 2024
0227656
recovery malleability
Amxx Jun 24, 2024
e3a8338
fix bug (inverse return values)
Amxx Jun 24, 2024
cbd2ff5
better private key gen
cairoeth Jun 24, 2024
194f19a
Update contracts/utils/cryptography/P256.sol
ernestognw Jun 24, 2024
704a12e
Fix hardhat tests and add documentation
ernestognw Jun 24, 2024
61d52a5
Update test/utils/cryptography/P256.test.js
Amxx Jun 24, 2024
242c796
Ensure lower s in Foundry tests
ernestognw Jun 24, 2024
787834d
Lint
ernestognw Jun 24, 2024
d8f4f7e
fix bug for valid signatures with large `r` values
cairoeth Jun 24, 2024
fc54017
run original wycheproof in hardhat
Amxx Jun 24, 2024
5a7887b
Merge remote-tracking branch 'amxx/feature/P256' into feature/P256
Amxx Jun 24, 2024
cc82c17
Update test/utils/cryptography/P256.test.js
Amxx Jun 24, 2024
a67e5a2
Almost fix tests
ernestognw Jun 24, 2024
4c93009
Bound r to N so for lower s values
ernestognw Jun 24, 2024
046463c
Remove unnecessary comment
ernestognw Jun 24, 2024
e4df1d1
Remove foundry wycheproof
ernestognw Jun 24, 2024
1bddcf5
Tests nit
ernestognw Jun 24, 2024
e5ba358
Update .changeset/odd-lobsters-wash.md
ernestognw Jun 24, 2024
2eecacf
Update test/utils/cryptography/P256.t.sol
ernestognw Jun 24, 2024
ced4fb8
Update P256.t.sol
Amxx Jun 24, 2024
b82af11
Merge branch 'master' into feature/P256
ernestognw Jun 24, 2024
c6a86d9
Add more docs and nit
ernestognw Jun 24, 2024
9b24014
Manage to compile without via-ir
ernestognw Jun 25, 2024
3616771
Improve comments
ernestognw Jun 25, 2024
be078b1
Remove unnecessary CI flag
ernestognw Jun 25, 2024
ecd3aa2
cleanup _jAdd with memory
Amxx Jun 25, 2024
d83e707
up
Amxx Jun 25, 2024
fbc11f5
Update contracts/utils/cryptography/P256.sol
Amxx Jun 25, 2024
9c88101
Apply suggestions from code review
Amxx Jun 25, 2024
b5e6bd7
Update hardhat.config.js
Amxx Jun 25, 2024
db76353
Update hardhat.config.js
Amxx Jun 25, 2024
0722d93
Update hardhat.config.js
Amxx Jun 25, 2024
306a5f6
Revert all changes to hardhat.config.js
Amxx Jun 26, 2024
e67a456
uniform style
Amxx Jun 26, 2024
1a8cb63
add bound checks to isOnCurve
Amxx Jun 26, 2024
3c3fa27
rename isOnCurve -> isValidPublicKey + add _isProperSignature helper
Amxx Jun 26, 2024
2fe4a16
Update contracts/utils/cryptography/P256.sol
ernestognw Jun 27, 2024
2420d13
Update contracts/utils/cryptography/P256.sol
ernestognw Jul 1, 2024
49f3ad9
Merge branch 'master' into feature/P256
ernestognw Jul 2, 2024
5314727
Enable --ir-minimum in forge coverage
ernestognw Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' into feature/P256
  • Loading branch information
@Amxx
Amxx authored Mar 13, 2024
commit 41aaf71139f66b9f67aa9dba769fcf29528b326e

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.