Skip to content

StorageSlot library : add storage slot derivation tooling and UDVT typed slot representation. #4965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Amxx wants to merge 24 commits into from
Closed

StorageSlot library : add storage slot derivation tooling and UDVT typed slot representation. #4965

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
d30144b
Add storage slot derivation tooling and UDVT typed slot representation.
Amxx Mar 18, 2024
e282a33
generate fuzzing tests
Amxx Mar 18, 2024
8705253
update hardhat to support cancun
Amxx Mar 18, 2024
f6bc398
fix cassing
Amxx Mar 18, 2024
45a7048
update hardhat-ignore-warnings
Amxx Mar 18, 2024
1ac21fd
fix hardhat-expose exclusion
Amxx Mar 18, 2024
a13c2bb
fix test
Amxx Mar 18, 2024
3f96b4c
re-enable variant testing for mapping key
Amxx Mar 18, 2024
c592c26
add support for string and bytes keys in mapping derivation
Amxx Mar 19, 2024
7c5b4c6
apply recommandations for PR
Amxx Mar 19, 2024
88b3c19
divide into 3 libraries
Amxx Mar 20, 2024
97b3048
Update .changeset/kind-planets-cough.md
Amxx Mar 20, 2024
38f3143
add changeset
Amxx Mar 20, 2024
c1a83f1
min diff
Amxx Mar 20, 2024
b6ff468
Update scripts/generate/templates/StorageSlot.js
Amxx Mar 20, 2024
f19086c
fix lint
Amxx Mar 20, 2024
3c11e1d
move UDVT to types/TypedSlot.sol
Amxx Mar 20, 2024
24a584b
changeset
Amxx Mar 20, 2024
4676af3
Update .changeset/kind-planets-cough.md
Amxx Mar 20, 2024
cd62c3d
doc
Amxx Mar 20, 2024
921a46d
Merge branch 'features/expended-storage-slot' of https://github.com/A…
Amxx Mar 20, 2024
2cd2c38
codespell
Amxx Mar 20, 2024
6445973
update
Amxx Mar 20, 2024
40c4943
rename
Amxx Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update
  • Loading branch information
@Amxx
Amxx committed Mar 20, 2024
commit 644597333ab33d3ae8ed7620c0ee390b1ceb2022
2 changes: 1 addition & 1 deletion .changeset/gorgeous-badgers-vanish.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
'openzeppelin-solidity': minor
---

`SlotDerivation`: Add library for storage slot derivation.
`SlotDerivation`: Add a library of methods for derivating common storage slots.
12 changes: 6 additions & 6 deletions contracts/utils/TransientSlot.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,18 +13,18 @@ import {TypedSlot} from "./types/TypedSlot.sol";
*
* Example usage:
* ```solidity
* contract ReentrancyGuard {
* contract Lock {
* using TypedSlot for bytes32;
* using TransientSlot for *;
*
* bytes32 internal constant _REENTRANCY_SLOT = 0x9b779b17422d0df92223018b32b4d1fa46e071723d6817e2486d003becc55f00;
* bytes32 internal constant _LOCK_SLOT = 0xf4678858b2b588224636b8522b729e7722d32fc491da849ed75b3fdf3c84f542;
*
* modifier nonReentrant() {
* require(!_REENTRANCY_SLOT.asBooleanSlot().tload());
* modifier locked() {
* require(!_LOCK_SLOT.asBooleanSlot().tload());
*
* _REENTRANCY_SLOT.asBooleanSlot().tstore(true);
* _LOCK_SLOT.asBooleanSlot().tstore(true);
* _;
* _REENTRANCY_SLOT.asBooleanSlot().tstore(false);
* _LOCK_SLOT.asBooleanSlot().tstore(false);
* }
* }
* ```
Expand Down
12 changes: 6 additions & 6 deletions scripts/generate/templates/TransientSlot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,18 +14,18 @@ import {TypedSlot} from "./types/TypedSlot.sol";
*
* Example usage:
* \`\`\`solidity
* contract ReentrancyGuard {
* contract Lock {
* using TypedSlot for bytes32;
* using TransientSlot for *;
*
* bytes32 internal constant _REENTRANCY_SLOT = 0x9b779b17422d0df92223018b32b4d1fa46e071723d6817e2486d003becc55f00;
* bytes32 internal constant _LOCK_SLOT = 0xf4678858b2b588224636b8522b729e7722d32fc491da849ed75b3fdf3c84f542;
*
* modifier nonReentrant() {
* require(!_REENTRANCY_SLOT.asBooleanSlot().tload());
* modifier locked() {
* require(!_LOCK_SLOT.asBooleanSlot().tload());
*
* _REENTRANCY_SLOT.asBooleanSlot().tstore(true);
* _LOCK_SLOT.asBooleanSlot().tstore(true);
* _;
* _REENTRANCY_SLOT.asBooleanSlot().tstore(false);
* _LOCK_SLOT.asBooleanSlot().tstore(false);
* }
* }
* \`\`\`
Expand Down