Skip to content

Replace deprecated throw with assert in Solidity tests #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
facuspagnuolo merged 2 commits into from
Nov 21, 2017
Merged

Replace deprecated throw with assert in Solidity tests #506

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d54b86
Replace deprecated throw with assert in Solidity tests
TalAter Oct 17, 2017
5fc53b6
Replaced assert with require
TalAter Nov 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Replaced assert with require
  • Loading branch information
@TalAter
TalAter committed Nov 18, 2017
commit 5fc53b6f2f49b121d42682ff3834e5e41d051ba3
2 changes: 1 addition & 1 deletion test/helpers/ReentrancyAttack.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ pragma solidity ^0.4.11;
contract ReentrancyAttack {

function callSender(bytes4 data) {
assert(msg.sender.call(data));
require(msg.sender.call(data));
}

}
2 changes: 1 addition & 1 deletion test/helpers/ReentrancyMock.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ contract ReentrancyMock is ReentrancyGuard {
if(n > 0) {
count();
bool result = this.call(func, n - 1);
assert(result == true);
require(result == true);
}
}

Expand Down