Deprecate SafeERC20.safeIncreaseAllowance and SafeERC20.safeDecreaseAllowance #5259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a26e987 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
cairoeth
reviewed
Oct 15, 2024
Contributor
cairoeth
left a comment
cairoeth
left a comment
There was a problem hiding this comment.
should forceApprove also have a comment?
Co-authored-by: cairo <[email protected]>
Collaborator
Author
No deprecation, but a comment yes maybe |
…://github.com/Amxx/openzeppelin-contracts into 5_1_rc/erc20/deprecate_safe_increase_decrease
cairoeth
previously approved these changes
Oct 16, 2024
3 tasks
cairoeth
approved these changes
Oct 17, 2024
Contributor
cairoeth
left a comment
cairoeth
left a comment
There was a problem hiding this comment.
I'm not a big fan of marking safeIncreaseAllowance and safeDecreaseAllowance as deprecated given their common usage in production contracts, so I opened #5262, which is the same but without the deprecation. I'll still approve this in case you think deprecation still makes sense despite the usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
npx changeset add)