Skip to content

Solium run and Solium version update #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
azavalla wants to merge 4 commits into from
Closed

Solium run and Solium version update #556

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0711386
updated soliumrc - Solium v1 compatible
azavalla Nov 12, 2017
31a6220
refactor
azavalla Nov 12, 2017
d36afa8
abstract base contracts visibility internal -> public
azavalla Nov 13, 2017
bcccd39
explicit visibility of Crowdsale function
azavalla Nov 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
abstract base contracts visibility internal -> public
  • Loading branch information
@azavalla
azavalla committed Nov 13, 2017
commit d36afa815719779f729430ff69564f712f222fdc
4 changes: 1 addition & 3 deletions contracts/crowdsale/Crowdsale.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,7 @@ contract Crowdsale {
uint256 _endTime,
uint256 _rate,
address _wallet
)
internal
{
) {
require(_startTime >= now);
require(_endTime >= _startTime);
require(_rate > 0);
Expand Down
2 changes: 1 addition & 1 deletion contracts/lifecycle/Destructible.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import "../ownership/Ownable.sol";
*/
contract Destructible is Ownable {

function Destructible() internal payable { }
function Destructible() public payable { }

/**
* @dev Transfers the current balance to the owner and terminates the contract.
Expand Down
2 changes: 1 addition & 1 deletion contracts/lifecycle/TokenDestructible.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import "../token/ERC20Basic.sol";
*/
contract TokenDestructible is Ownable {

function TokenDestructible() internal payable { }
function TokenDestructible() public payable { }

/**
* @notice Terminate contract and refund to owner
Expand Down