Fix/511 #563
Closed
Fix/511 #563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crazy and temporary solution, but it's working.
Crazy and temporary solution, but it's working.
Crazy and temporary solution, but it's working.
Crazy and temporary solution, but it's working.
Crazy and temporary solution, but it's working.
Crazy and temporary solution, but it's working.
… to "pure" where it makes sense
Contributor
|
Travis fails because you didn't update Thanks and sorry we ended up not merging this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #511
Had only changed 0.4.11 to 0.4.17 where replaced "constant" to "pure" or "view".
Decided not to touch ERC20.sol and ERC20Basic.sol for now, because changing them to 0.4.17 may affect a lot of people, and solc does not emmit warnings for them.
At the same time changed BasicToken and StandartToken because BasicToken uses SafeMath which requires 0.4.17 now.