Skip to content

Solium Integration, Linting Refactor #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frangio merged 9 commits into from
Jan 15, 2018
Merged

Solium Integration, Linting Refactor #673

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c1244d6
updated soliumrc - Solium v1 compatible
azavalla Nov 12, 2017
d4dc4b2
fix: remove warning on timestamp usage
shrugs Jan 15, 2018
e0f3fea
feat: add solium linting to travis, npm script
shrugs Jan 15, 2018
4d263b7
fix: the result of 'npm run lint:sol:fix'
shrugs Jan 15, 2018
b2e2d9a
fix: solium errors - indentation only
shrugs Jan 15, 2018
e60aee6
fix: solium errors - blank-line only
shrugs Jan 15, 2018
bd2f177
fix: solium errors - function-order only
shrugs Jan 15, 2018
3b48a67
fix: solium errors - whitespace related
shrugs Jan 15, 2018
955517d
fix: add ignore directives to SampleCrowdsale and SimpleToken
shrugs Jan 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: add ignore directives to SampleCrowdsale and SimpleToken
  • Loading branch information
@shrugs
shrugs committed Jan 15, 2018
commit 955517dc2ef4e6cd8b1f8538323ddcec170c280a
6 changes: 3 additions & 3 deletions contracts/examples/SampleCrowdsale.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ import "../token/MintableToken.sol";
*/
contract SampleCrowdsaleToken is MintableToken {

string public constant name = "Sample Crowdsale Token";
string public constant symbol = "SCT";
uint8 public constant decimals = 18;
string public constant name = "Sample Crowdsale Token"; // solium-disable-line uppercase
string public constant symbol = "SCT"; // solium-disable-line uppercase
uint8 public constant decimals = 18; // solium-disable-line uppercase

}

Expand Down
6 changes: 3 additions & 3 deletions contracts/examples/SimpleToken.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ import "../token/StandardToken.sol";
*/
contract SimpleToken is StandardToken {

string public constant name = "SimpleToken";
string public constant symbol = "SIM";
uint8 public constant decimals = 18;
string public constant name = "SimpleToken"; // solium-disable-line uppercase
string public constant symbol = "SIM"; // solium-disable-line uppercase
uint8 public constant decimals = 18; // solium-disable-line uppercase

uint256 public constant INITIAL_SUPPLY = 10000 * (10 ** uint256(decimals));

Expand Down