Skip to content

Decouple RefundVault from RefundableCrowdsale #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brunobar79 wants to merge 7 commits into from
Closed

Decouple RefundVault from RefundableCrowdsale #734

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c47d8c9
update RefundableCrowdsale constructor
brunobar79 Feb 13, 2018
985864f
update RefundableCrowdsaleImpl constructor
brunobar79 Feb 13, 2018
d6553fb
update SampleCrowdsale
brunobar79 Feb 13, 2018
4f27546
add missing parameter to CappedCrowdsale.test
brunobar79 Feb 13, 2018
c47a793
update tests for RefundableCrowdsale
brunobar79 Feb 13, 2018
f4288a2
add {from: owner} to params
brunobar79 Feb 13, 2018
9e7a45e
keep parameters order consistent
brunobar79 Feb 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update tests for RefundableCrowdsale
  • Loading branch information
@brunobar79
brunobar79 committed Feb 13, 2018
commit c47a793aca32ca3ce86b65e23975f2bdd6b44eca
23 changes: 21 additions & 2 deletions test/crowdsale/RefundableCrowdsale.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ require('chai')

const RefundableCrowdsale = artifacts.require('RefundableCrowdsaleImpl');
const MintableToken = artifacts.require('MintableToken');
const RefundVault = artifacts.require('RefundVault');

contract('RefundableCrowdsale', function ([_, owner, wallet, investor]) {
const rate = new BigNumber(1000);
Expand All @@ -30,15 +31,33 @@ contract('RefundableCrowdsale', function ([_, owner, wallet, investor]) {
this.afterEndTime = this.endTime + duration.seconds(1);

this.token = await MintableToken.new();
this.vault = await RefundVault.new(wallet);

this.crowdsale = await RefundableCrowdsale.new(
this.startTime, this.endTime, rate, wallet, goal, this.token.address, { from: owner }
this.startTime,
this.endTime,
rate,
wallet,
goal,
this.vault.address,
this.token.address
);

await this.token.transferOwnership(this.crowdsale.address);
await this.vault.transferOwnership(this.crowdsale.address);
});

describe('creating a valid crowdsale', function () {
it('should fail with zero goal', async function () {
await RefundableCrowdsale.new(this.startTime, this.endTime, rate, wallet, 0, { from: owner })
await RefundableCrowdsale.new(
this.startTime,
this.endTime,
rate,
wallet,
0,
this.vault.address,
this.token.address
)
.should.be.rejectedWith(EVMRevert);
});
});
Expand Down