Skip to content

Add Transfer event to Burnable Token. #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shrugs merged 2 commits into from
Feb 20, 2018
Merged

Add Transfer event to Burnable Token. #735

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
167a24f
Add Transfer event to Burnable Token.
rstormsf Feb 13, 2018
146e3fa
Merge branch 'master' into burnable_transfer
shrugs Feb 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions contracts/token/ERC20/BurnableToken.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,6 @@ contract BurnableToken is BasicToken {
balances[burner] = balances[burner].sub(_value);
totalSupply_ = totalSupply_.sub(_value);
Burn(burner, _value);
Transfer(burner, address(0), _value);
}
}
9 changes: 7 additions & 2 deletions test/token/BurnableToken.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,16 @@ contract('BurnableToken', function ([owner]) {

it('emits a burn event', async function () {
const { logs } = await this.token.burn(amount, { from });

assert.equal(logs.length, 1);
const ZERO_ADDRESS = '0x0000000000000000000000000000000000000000';
assert.equal(logs.length, 2);
assert.equal(logs[0].event, 'Burn');
assert.equal(logs[0].args.burner, owner);
assert.equal(logs[0].args.value, amount);

assert.equal(logs[1].event, 'Transfer');
assert.equal(logs[1].args.from, owner);
assert.equal(logs[1].args.to, ZERO_ADDRESS);
assert.equal(logs[1].args.value, amount);
});
});

Expand Down