TaxedToken implementation that charges a fee for token transfers. #788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrugs
reviewed
Mar 6, 2018
|
|
||
| balances[msg.sender] = balances[msg.sender].sub(_value); | ||
|
|
||
| uint256 fee = Math.min256(_value.mul(transferFeePercentage).div(100), maxTransferFee); |
Contributor
There was a problem hiding this comment.
is it possible to use super.transfer() here, to avoid reimplementing lines 23, 24, 27, 32, 33 and 38?
Author
There was a problem hiding this comment.
yes, good point! I think this is possible and is the cleaner solution. I will update the PR w/ improvement
Contributor
|
LGTM, but haven't done a thorough look-through of the code to make sure all the math works, etc. Requesting a review from a fellow maintainer :) |
Contributor
|
Closing due to staleness. Also, this would be better implemented in the current version of OpenZeppelin by overriding the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #787
🚀 Description
An interesting erc20 token use-case I keep seeing is a 'taxed' transfer (i.e. a small fee (for example 1%) is diverted to a feeAccount in
transfer). This PR implements that functionality and includes corresponding unit-tests.npm run lint:all:fix).