Added PausableCrowdsale contract#832
Merged
frangio merged 32 commits intoOpenZeppelin:masterfrom Dec 14, 2018
TalAter:feature/pausable-crowdsale
Merged
Added PausableCrowdsale contract#832frangio merged 32 commits intoOpenZeppelin:masterfrom TalAter:feature/pausable-crowdsale
frangio merged 32 commits intoOpenZeppelin:masterfrom
TalAter:feature/pausable-crowdsale
Conversation
Contributor
Author
Contributor
Author
|
Small update: our crowdsale which used this contract successfully closed last week raising over 40,000 Ether. No issues were found in this trial by fire. |
amateescu
reviewed
Aug 31, 2018
amateescu
suggested changes
Aug 31, 2018
amateescu
left a comment
There was a problem hiding this comment.
We should change the inheritance order to is Pausable, Crowdsale.
…aph impossible" error
Contributor
Author
|
Nice catch @amateescu |
Contributor
Author
|
@TalAter looking at the Travis CI failures, I think the test coverage from this PR needs to be updated. |
Comply with new max line length
…PausableCrowdsale tests
Contributor
Author
|
Brought this branch up to speed with the latest changes done to HEAD.
|
Contributor
|
Great work @TalAter! We're wrapping up the 2.0 release candidate this week so I'll get back to this in a few days. |
…y into feature/pausable-crowdsale
frangio
reviewed
Dec 5, 2018
Contributor
frangio
previously approved these changes
Dec 11, 2018
nventuro
reviewed
Dec 12, 2018
nventuro
reviewed
Dec 12, 2018
nventuro
reviewed
Dec 12, 2018
nventuro
reviewed
Dec 13, 2018
nventuro
approved these changes
Dec 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Description
Introduces a new contract, the
PausableCrowdsale.PausableCrowdsaleextends the standardCrowdsalecontract, making it pausable. This is a useful failsafe mechanism used by many crowdsales, but isn't yet offered byzeppelin-solidity.buyTokens()or simple transactions will revert.🦆🦆🦆🦆🦆🦆
npm run lint:all:fix).