Skip to content

[OUDS] add title attibutes, bootstrap html handling and a callout on Breadcrumb#3010

Merged
vprothais merged 8 commits into
ouds/mainfrom
ouds/main-breadcrumb-enhancement-after-demo
Jun 11, 2025
Merged

[OUDS] add title attibutes, bootstrap html handling and a callout on Breadcrumb#3010
vprothais merged 8 commits into
ouds/mainfrom
ouds/main-breadcrumb-enhancement-after-demo

Conversation

@MaxLardenois
Copy link
Copy Markdown
Collaborator

@MaxLardenois MaxLardenois commented Jun 6, 2025

Related issues

closes #3008

Description

  1. Add overflow hidden and no-wrap on last li of the breadcrumb
  2. Add callout to note that the responsive part should not be used (too long titles)
  3. Add titles on links

Motivation & Context

Breadcrumb was not displayed correctly with Bootstrap DOM.

Types of change

  • New feature (non-breaking change which adds functionality)

Live previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices; I have at least run axe

Design

  • My change respects the design guidelines defined in Orange Design System
  • My change is compatible with a responsive display

Development

  • My change follows the developer guide
  • I have added JavaScript unit tests to cover my changes
  • I have added SCSS unit tests to cover my changes

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • My change introduces changes to the migration guide
  • My new component is well displayed in Storybook
  • My new component is compatible with RTL
  • Manually run BrowserStack tests
  • Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
  • Code review
  • Design review
  • A11y review

@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 6, 2025

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit eef8edc
🔍 Latest deploy log https://app.netlify.com/projects/boosted/deploys/6848479363baa60008984309
😎 Deploy Preview https://deploy-preview-3010--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@MaxLardenois MaxLardenois marked this pull request as ready for review June 6, 2025 13:09
@boosted-bot boosted-bot moved this from In Progress / Draft to Need Dev Review in 🟣 [Orange-Boosted-Bootstrap] PRs Board Jun 6, 2025
Comment thread site/content/docs/0.4/components/breadcrumb.md
Comment thread site/content/docs/0.4/components/breadcrumb.md Outdated
Copy link
Copy Markdown
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rendering looks good to me, let's wait a bit if anyone else wants to review as well

@boosted-bot boosted-bot moved this from Need Dev Review to Need Lead Dev Review in 🟣 [Orange-Boosted-Bootstrap] PRs Board Jun 10, 2025
Comment thread site/content/docs/0.4/components/breadcrumb.md
@vprothais vprothais merged commit 627094b into ouds/main Jun 11, 2025
19 checks passed
@vprothais vprothais deleted the ouds/main-breadcrumb-enhancement-after-demo branch June 11, 2025 10:16
@github-project-automation github-project-automation Bot moved this from Need Lead Dev Review to Done in 🟣 [Orange-Boosted-Bootstrap] PRs Board Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⚛️ component 📖 documentation Improvements or additions to documentation 🧩 enhancement

Projects

Development

Successfully merging this pull request may close these issues.

4 participants