Fix: Explicitly pass API keys to update_settings in settings dialog

The to_dict() method on AppSettings excludes secure keys (API keys) for
security reasons. This meant that when _on_ok called update_settings with
**new_settings.to_dict(), the API keys were never passed and thus never
saved to secure storage.

Fixed by explicitly adding visual_crossing_api_key and openrouter_api_key
to the settings dict before calling update_settings.

Also updated test_secure_storage_integration to expect 5 secure key loads
instead of 4 (added openrouter_api_key).

src/accessiweather/dialogs/settings_dialog.py

@@ -338,7 +338,12 @@ async def _on_ok(self, widget):
             old_startup_enabled = self.config_manager.get_settings().startup_enabled
 
             # Update configuration
-            success = self.config_manager.update_settings(**new_settings.to_dict())
+            # Note: to_dict() excludes secure keys (API keys) so we must pass them explicitly
+            settings_dict = new_settings.to_dict()
+            # Add secure keys that are excluded from to_dict() for security
+            settings_dict["visual_crossing_api_key"] = new_settings.visual_crossing_api_key
+            settings_dict["openrouter_api_key"] = new_settings.openrouter_api_key
+            success = self.config_manager.update_settings(**settings_dict)
 
             # Handle startup setting changes
             if success:

tests/test_secure_storage_integration.py

@@ -68,8 +68,8 @@ def test_secure_storage_migration(mock_app, mock_keyring):
     manager.load_config()
 
     # Verify keyring get_password was called to load secure keys
-    # (visual_crossing_api_key, github_app_id, github_app_private_key, github_app_installation_id)
-    assert mock_keyring.get_password.call_count == 4
+    # (visual_crossing_api_key, openrouter_api_key, github_app_id, github_app_private_key, github_app_installation_id)
+    assert mock_keyring.get_password.call_count == 5
     # No set_password calls during load
     assert mock_keyring.set_password.call_count == 0