-
Notifications
You must be signed in to change notification settings - Fork 37
Geolocation #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Geolocation #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 similar comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you unit test this method? Coverage is brought down now, which I want to avoid.
1 similar comment
All those methods were covered by unit tests, though I didn't add phpunit @Covers reference for them, my mistake |
No problem, nice job you did by adding the GPS stuff! |
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need
Geolocation of images, read GPS coordinates from exif gps data
Solution
Both native and exiftool adapters mapData methods have been updated to extract GPS coordinates from exif data
There is no point on having GPS coordinates manipulation on a library which purpose is exif data extraction so I've normalize them to Decimal Degrees format and created juliangut/gps for this coordinates manipulation
Additionally
Found an unused variable in getIptcData method on native adapter
sorry for the spaces removed on empty lines, editor config