Skip to content

Conversation

juliangut
Copy link
Contributor

Need

Geolocation of images, read GPS coordinates from exif gps data

Solution

Both native and exiftool adapters mapData methods have been updated to extract GPS coordinates from exif data

There is no point on having GPS coordinates manipulation on a library which purpose is exif data extraction so I've normalize them to Decimal Degrees format and created juliangut/gps for this coordinates manipulation

Additionally

Found an unused variable in getIptcData method on native adapter

sorry for the spaces removed on empty lines, editor config

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.29%) to 93.85% when pulling 272fc2d on juliangut:master into f91e9ca on Miljar:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-2.29%) to 93.85% when pulling 272fc2d on juliangut:master into f91e9ca on Miljar:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.29%) to 93.85% when pulling 272fc2d on juliangut:master into f91e9ca on Miljar:master.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you unit test this method? Coverage is brought down now, which I want to avoid.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.38%) to 96.52% when pulling 61533c9 on juliangut:master into f91e9ca on Miljar:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.38%) to 96.52% when pulling 61533c9 on juliangut:master into f91e9ca on Miljar:master.

@juliangut
Copy link
Contributor Author

All those methods were covered by unit tests, though I didn't add phpunit @Covers reference for them, my mistake

@Miljar
Copy link
Collaborator

Miljar commented Mar 29, 2015

No problem, nice job you did by adding the GPS stuff!

Miljar added a commit that referenced this pull request Mar 29, 2015
@Miljar Miljar merged commit fe64685 into PHPExif:master Mar 29, 2015
@juliangut
Copy link
Contributor Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants