[Refactoring] Move automatic-wallet-backup code out of init.cpp #2362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
random-zebra
added
Refactoring
Wallet
Startup
random-zebra
force-pushed
the
202105_autobackup-refactor
branch
2 times, most recently
from
0421064 to
d6ce6cf
Compare
>>> backports bitcoin/bitcoin@fab9107
random-zebra
force-pushed
the
202105_autobackup-refactor
branch
from
d6ce6cf to
4dfc8e0
Compare
furszy
approved these changes
May 7, 2021
Fuzzbawls
approved these changes
May 11, 2021
furszy
added a commit
that referenced
this pull request
Jul 6, 2021
f36c4d0 [Refactor] InitLoadWallet: CreateWalletFromFile before AutoBackupWallet (random-zebra) e24cdd5 wallet: remove not longer available "-printcoinstake" init flag. (furszy) 2603353 wallet: Create initial wallet backup after initialization. Plus fix "Failed to create backup..." error at startup when the wallet hasn't been created yet. (furszy) 5fdc630 Walletdb: unify wallet backups cleanup. (furszy) 10ce576 Walletdb: unify sort backups file by last write. (furszy) 2e2d467 Wallet: unify wallet backup functions (furszy) 0cd6089 Wallet: Cleanup AutoBackupWallet [Step 1] (furszy) Pull request description: Was checking #2362 and wasn't able to contain myself from cleaning redundancies and code deduplication on the wallet auto-backup "feature". ACKs for top commit: random-zebra: ACK f36c4d0 Tree-SHA512: 4ff729e2f4012bf6166a891f67f7e7b93801bb398103023f1fca74a86a9c28db06b6194589444477af5846751c9b440890b8ee95560460e4d3219ccbc40f3277
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple refactoring. First two commits are coming from bitcoin#8768.
Other commits break up a big chunk of code from init.cpp into more manageable functions in wallet/walletdb.
This will make the implementation of auto-backups for multi-wallets cleaner (will now rebase #2337 on top of this one).