【Hackathon 9th Sprint No.1】add api compatibility for paddle.unique - part #76387

co63oc · 2025-11-13T00:57:35Z

PR Category

User Experience

PR Types

New features

Description

paddle.unique 兼容性修改
返回数据可能为数组或一项，使用装饰器方式修改
sorted 参数不影响返回结果，结果始终是排序，增加参数保持兼容性

paddle-bot · 2025-11-13T00:57:41Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

codecov-commenter · 2025-11-13T12:57:04Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@3e93582). Learn more about missing BASE report.

Additional details and impacted files

@@             Coverage Diff             @@
##             develop    #76387   +/-   ##
===========================================
  Coverage           ?   100.00%           
===========================================
  Files              ?         1           
  Lines              ?         5           
  Branches           ?         0           
===========================================
  Hits               ?         5           
  Misses             ?         0           
  Partials           ?         0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

co63oc · 2025-11-14T00:43:42Z

/re-run all-failed

co63oc · 2025-11-14T05:37:56Z

/re-run all-failed

co63oc · 2025-11-14T08:24:00Z

@zhwesky2010 CI已完成需要review

zhwesky2010 · 2025-11-14T09:55:41Z

python/paddle/tensor/manipulation.py

            Default: None.
        dtype(str|paddle.dtype|np.dtype, optional): The date type of `indices` or `inverse` tensor: int32 or int64.
            Default: int64.
+        sorted(bool, optional): Does not affect the return result, used for compatibility.


sorted=True
sorted=Fasle

两种情况下结果均一致吗

是一致的，is_sorted 设置为 true UniqueRawKernel 的参数 is_sorted 没有使用

zhwesky2010 · 2025-11-17T08:32:05Z

竞品有使用吗，这个任务需要做的是对齐运算结果，不用管paddle之前怎么写的。

先提交PaConvert测试吧，比对size超过1000的结果，sorted=True/False的结果比对。

co63oc · 2025-11-17T08:55:49Z

竞品有使用吗，这个任务需要做的是对齐运算结果，不用管paddle之前怎么写的。

先提交PaConvert测试吧，比对size超过1000的结果，sorted=True/False的结果比对。

因为PaConvert的CI需要paddle合入之后测试，所以先提交这里，已增加PaConvert PR
PaddlePaddle/PaConvert#758

参数sorted=True/False测试通过

torch sorted=False时也会排序

torch.unique(torch.arange(1001, 0, -1), sorted=False)

zhwesky2010 · 2025-11-18T11:36:32Z

torch的sorted也和paddle一样不会生效吗

co63oc · 2025-11-18T12:04:24Z

torch的sorted也和paddle一样不会生效吗

是的torch的没有生效

zhwesky2010 · 2025-11-24T12:25:36Z

python/paddle/tensor/manipulation.py

    return_counts=False,
    axis=None,
    dtype="int64",
+    sorted=True,


这个目前应该无法实现 API完全一致吧，参数顺序不同。

group_norm也有这个问题。不过这个没法判断数据类型了，只能新增加一个paddle.compat.unique了？

好的那增加paddle.compat.unique

@zhwesky2010 已增加paddle.compat.unique CI完成，PaConvert PaddlePaddle/PaConvert#758 修改测试通过

python/paddle/compat/__init__.py

python/paddle/tensor/manipulation.py

co63oc · 2025-12-02T11:49:49Z

/re-run all-failed

co63oc · 2025-12-02T22:00:34Z

/re-run all-failed

python/paddle/tensor/manipulation.py

co63oc · 2025-12-05T05:45:47Z

/re-run all-failed

SigureMo · 2025-12-08T11:36:16Z

python/paddle/compat/__init__.py

+    sorted: bool = True,
+    return_inverse: bool = False,
+    return_counts: bool = False,
+    dim=None,


需要添加类型提示

再提交PR加上

这个急么？为啥要等下个 PR？赶发版还是啥？

如果修改较多，CI不容易成功，所以拆为多个PR修改

啊？这个 PR 涉及 API 变动，什么时候这个也要拆了？有这时间 CI 都过完了

SigureMo · 2025-12-08T11:37:17Z

python/paddle/compat/__init__.py

+    return_inverse: bool = False,
+    return_counts: bool = False,
+    dim=None,
+) -> Tensor | tuple[Tensor, ...]:


使用 overload 避免返回多种类型

https://www.paddlepaddle.org.cn/documentation/docs/zh/develop/dev_guides/style_guide_and_references/type_annotations_specification_cn.html#canshuyingjinkenengshiyongchouxiangleixing-fanhuizhiyingjinkenengshiyongjutileixing

CI容易出错，我再提交PR加上

python/paddle/compat/__init__.py

Co-authored-by: Nyakku Shigure <[email protected]>

co63oc · 2025-12-16T00:15:27Z

/re-run all-failed

add api compatibility for paddle.unique

ac045fd

paddle-bot bot added the contributor External developers label Nov 13, 2025

co63oc changed the title ~~CI测试不review add api compatibility for paddle.unique [fluid_ops]~~ 【Hackathon 9th No.1】 add api compatibility for paddle.unique -part [fluid_ops] Nov 13, 2025

fix

8e5e6ac

co63oc changed the title ~~【Hackathon 9th No.1】 add api compatibility for paddle.unique -part [fluid_ops]~~ 【Hackathon 9th No.1】 add api compatibility for paddle.unique - part [fluid_ops] Nov 13, 2025

co63oc changed the title ~~【Hackathon 9th No.1】 add api compatibility for paddle.unique - part [fluid_ops]~~ add api compatibility for paddle.unique - part [fluid_ops] Nov 13, 2025

co63oc changed the title ~~add api compatibility for paddle.unique - part [fluid_ops]~~ [API compatibility] add api compatibility for paddle.unique - part [fluid_ops] Nov 13, 2025

co63oc changed the title ~~[API compatibility] add api compatibility for paddle.unique - part [fluid_ops]~~ 【Hackathon 9th Sprint No.1】add api compatibility for paddle.unique - part [fluid_ops] Nov 13, 2025

fix

80764fd

luotao1 mentioned this pull request Nov 13, 2025

【Hackathon 9th】开源贡献个人挑战赛冲刺赛 #76333

Open

luotao1 added the PaddlePaddle Hackathon label Nov 13, 2025

luotao1 assigned luotao1 and zhwesky2010 Nov 13, 2025

zhwesky2010 added the API Compatibility label Nov 13, 2025

co63oc added 2 commits November 13, 2025 17:03

fix

7a1d555

fix

fb311dd

This was referenced Nov 13, 2025

proxy: No such file or directory #76402

Closed

SSLError SSLCertVerificationError 错误 #76403

Closed

Merge branch 'develop' into m31

8b6e2d7

zhwesky2010 reviewed Nov 14, 2025

View reviewed changes

zhwesky2010 reviewed Nov 24, 2025

View reviewed changes

co63oc added 2 commits November 25, 2025 07:52

fix

68fca13

fix

379a6ea

co63oc mentioned this pull request Nov 25, 2025

【Hackathon 9th Sprint No.1】add api compatibility for paddle.unique - part PaddlePaddle/PaConvert#758

Open

zhwesky2010 reviewed Dec 2, 2025

View reviewed changes

python/paddle/compat/__init__.py Outdated Show resolved Hide resolved

python/paddle/tensor/manipulation.py Outdated Show resolved Hide resolved

fix

d8cc756

fix

8be342b

zhwesky2010 reviewed Dec 3, 2025

View reviewed changes

python/paddle/tensor/manipulation.py Show resolved Hide resolved

python/paddle/tensor/manipulation.py Outdated Show resolved Hide resolved

co63oc added 4 commits December 4, 2025 08:01

Merge branch 'develop' into m31

c9b57aa

fix

f5c9c30

fix

659bfee

fix

f845a1f

zhwesky2010 previously approved these changes Dec 8, 2025

View reviewed changes

luotao1 assigned SigureMo Dec 8, 2025

luotao1 requested a review from SigureMo December 8, 2025 11:23

SigureMo reviewed Dec 8, 2025

View reviewed changes

co63oc added 2 commits December 15, 2025 12:35

Merge branch 'develop' into m31

76f6321

fix

dd247c8

co63oc dismissed zhwesky2010’s stale review via dd247c8 December 15, 2025 07:49

fix

ea1c1f1

SigureMo reviewed Dec 15, 2025

View reviewed changes

python/paddle/compat/__init__.py Outdated Show resolved Hide resolved

co63oc and others added 2 commits December 15, 2025 20:25

Update python/paddle/compat/__init__.py

71af57d

Co-authored-by: Nyakku Shigure <[email protected]>

fix

6d41363

SigureMo approved these changes Dec 15, 2025

View reviewed changes

luotao1 added the skip-ci: static-check label Dec 16, 2025

luotao1 merged commit 11d80ef into PaddlePaddle:develop Dec 16, 2025
103 of 109 checks passed

luotao1 changed the title ~~【Hackathon 9th Sprint No.1】add api compatibility for paddle.unique - part [fluid_ops]~~ 【Hackathon 9th Sprint No.1】add api compatibility for paddle.unique - part Dec 16, 2025

【Hackathon 9th Sprint No.1】add api compatibility for paddle.unique - part #76387

【Hackathon 9th Sprint No.1】add api compatibility for paddle.unique - part #76387

Conversation

co63oc commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Category

PR Types

Description

Uh oh!

paddle-bot bot commented Nov 13, 2025

Uh oh!

codecov-commenter commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

co63oc commented Nov 14, 2025

Uh oh!

co63oc commented Nov 14, 2025

Uh oh!

co63oc commented Nov 14, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

co63oc Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zhwesky2010 commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

co63oc commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zhwesky2010 commented Nov 18, 2025

Uh oh!

co63oc commented Nov 18, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

co63oc commented Dec 2, 2025

Uh oh!

co63oc commented Dec 2, 2025

Uh oh!

Uh oh!

Uh oh!

co63oc commented Dec 5, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

co63oc commented Dec 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

co63oc commented Nov 13, 2025 •

edited

Loading

codecov-commenter commented Nov 13, 2025 •

edited

Loading

co63oc Nov 14, 2025 •

edited

Loading

zhwesky2010 commented Nov 17, 2025 •

edited

Loading

co63oc commented Nov 17, 2025 •

edited

Loading