【Hackathon 9th Sprint No.06】NO.06 paddle.nn.MaxPool2D兼容性增强 #76714

WintersMontagne10335 · 2025-12-01T09:41:58Z

PR Category

Operator Mechanism

PR Types

New features

Description

paddle.nn.MaxPool2D兼容性增强

paddle-bot · 2025-12-01T09:42:04Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

codecov-commenter · 2025-12-02T11:29:48Z

Codecov Report

❌ Patch coverage is 80.25210% with 94 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@fdac870). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
.../interface/infer_symbolic_shape/unary_infer_sym.cc	0.00%	82 Missing ⚠️
python/paddle/nn/functional/pooling.py	70.00%	6 Missing ⚠️
...terface/infer_symbolic_shape/backward_infer_sym.cc	0.00%	3 Missing ⚠️
paddle/phi/kernels/impl/pool_kernel_impl.h	93.75%	3 Missing ⚠️

❌ Your patch status has failed because the patch coverage (80.25%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             develop   #76714   +/-   ##
==========================================
  Coverage           ?   80.25%           
==========================================
  Files              ?       11           
  Lines              ?      476           
  Branches           ?        0           
==========================================
  Hits               ?      382           
  Misses             ?       94           
  Partials           ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

WintersMontagne10335 · 2025-12-08T03:13:04Z

/re-run all-failed

zhwesky2010 · 2025-12-08T04:44:44Z

#76457 这个PR还需要吗

zhwesky2010

看一下覆盖率CI，确保增加的逻辑都能测试到，同时在PaConvert里也加一些dilation的测试，确保与torch结果也是对齐的。

zhwesky2010 · 2025-12-08T04:45:45Z

python/paddle/nn/functional/pooling.py

-            output = _C_ops.max_pool2d_with_index(
-                x, kernel_size, stride, padding, False, False, ceil_mode
-            )
+            if dilation_greater_than_one:


能否直接在原来的max_pool2d_with_index上加参数dilation

这个可以，最新的commit实现了

zhwesky2010 · 2025-12-08T04:47:02Z

python/paddle/nn/functional/pooling.py

-        op_type = 'max_pool2d_with_index' if return_mask else "pool2d"
+        if return_mask:
+            if dilation_greater_than_one:
+                op_type = 'max_pool2d_with_dilations_and_index'


能否直接在原来op上加参数。这样op会太多了比较复杂

可以在 max_pool2d_with_index 上加参数，但是没有办法在 pool_2d 上加参数。

zhwesky2010 · 2025-12-08T04:48:10Z

paddle/phi/ops/yaml/ops.yaml

  backward : max_grad
  interfaces : paddle::dialect::InferSymbolicShapeInterface, paddle::dialect::LayoutTransformationInterface

+- op : max_pool2d_with_dilations


现在op有点太多了，只是多一个兼容的参数，还是在原来上改吧

原先的PR是那样做的，会有一大堆兼容性问题，很难在pool_2d上加参数。

zhwesky2010 · 2025-12-08T04:50:53Z

paddle/fluid/pir/dialect/operator/interface/infer_symbolic_shape/backward_infer_sym.cc

  return true;
 }

+bool MaxPool2dWithDilationsGradOpInferSymbolicShape(


infer_sym这些需要开CINN模式来测

https://github.com/PaddlePaddle/Paddle/blob/develop/test/legacy_test/op_test.py#L2941 ,测这个需要 check_symbol_infer（默认值为True)、check_pir 都为True，check_pir 已经设置为True。

WintersMontagne10335 · 2025-12-08T05:07:39Z

#76457 这个PR还需要吗

不需要了

WintersMontagne10335 · 2025-12-15T01:13:04Z

@zhwesky2010 老师有时间 review 一下吧，ci 基本通过了。
approval 和 static-check 是因为 api 变动，需要对应的研发老师审核。
coverage 已经确定了问题，本地打 log 能覆盖到，正在 issue 里和那边的老师沟通。

WintersMontagne10335 · 2025-12-15T04:00:11Z

/re-run all-failed

zhwesky2010 · 2025-12-15T14:16:37Z

python/paddle/nn/functional/pooling.py


    # use 2d to implement 1d should expand padding in advance.
    padding = _expand_low_nd_padding(padding)
+    dilation = convert_to_list(1, 2, 'pool_dilation')


这里是一个写死的dilation吗？

这个是 max_pool1d，暂时还不支持 dilation，因为它调用了cpp层的 max_pool2d_with_index，所以这里给一个写死的值做兼容

zhwesky2010 · 2025-12-15T14:17:02Z

python/paddle/nn/functional/pooling.py

-                "data_format": data_format,
-            },
-        )
+        if return_mask:


return_mask为何影响到dilation是否传入

这个也是 max_pool1d，也是为了兼容cpp层的修改

zhwesky2010 · 2025-12-15T14:19:17Z

python/paddle/nn/functional/pooling.py

        )

+    dilation = convert_to_list(dilation, 2, 'pool_dilation')
+    dilation_greater_than_one = dilation[0] > 1 or dilation[1] > 1


这个>1还得额外搞个分支吗，不能传入到kernel里再判断吗。

这样写，静态图下也根本跑不了吧。静态图组网时都没有数值。

传入到kernel里再判断：done

zhwesky2010 · 2025-12-15T14:21:01Z

python/paddle/nn/functional/pooling.py

            )
+            return output if return_mask else output[0]
+        else:
+            if dilation_greater_than_one:


如果help这个分支有问题，可以不修改。这个功能加到dynamic_or_pir下。

python尽量不要去加太多分支和逻辑。pool_2d的兼容性问题是什么？是在老IR分支吗，老IR可以不维护

dilation_greater_than_one 不需要了，最新 commit 将相关分支下沉到 cpp 了

WintersMontagne10335 · 2025-12-16T02:40:02Z

test_layers 报错了，我再看看

zhwesky2010

这样改我感觉是可以的，python层没有太多trick了。
但是目前dilation为何只给max_pool2d来使用，这个题目本意是max_pool1/2/3中缺dilation功能的都支持

zhwesky2010 · 2025-12-17T08:57:13Z

python/paddle/nn/functional/pooling.py

            )
            return output if return_mask else output[0]
        else:
-            return _C_ops.pool2d(


是说直接修改pool2d会引起很多兼容性问题对吧，所以改名为一个新op：max_pool2d_with_dilations

avg 等等其他算子也依赖 pool2d，对于它们来说，dilation是冗余的

WintersMontagne10335 · 2025-12-17T09:50:42Z

这样改我感觉是可以的，python层没有太多trick了。但是目前dilation为何只给max_pool2d来使用，这个题目本意是max_pool1/2/3中缺dilation功能的都支持

这个是黑客松的赛题之一，赛题要求是给 max_pool2d 新增参数 dilation。
老师可以联系一下涛姐，让她在黑客松再发一下 1d 和 3d 任务~
说实话，这个工作量已经够大了，快一个月了，还要再做 1d 和 3d，我真顶不住了哈哈。

WintersMontagne10335 · 2025-12-18T12:08:14Z

/re-run all-failed

WintersMontagne10335 · 2025-12-18T12:11:57Z

/re-run all-failed

WintersMontagne10335 · 2025-12-18T12:12:39Z

/re-run all-failed

WintersMontagne10335 · 2025-12-18T12:13:25Z

/re-run all-failed

WintersMontagne10335 · 2025-12-18T12:13:28Z

/re-run all-failed

WintersMontagne10335 · 2025-12-18T12:13:31Z

/re-run all-failed

SigureMo · 2025-12-18T12:14:54Z

一条流水线（workflow，比如 CI、CI build）里有任何一个 job 仍在运行的话，rerun 是没效果的，别发了，我这邮件一直响 😂

SigureMo · 2025-12-18T12:19:03Z

目前这个 rerun comment 是写在哪里的文档里了？需要更新下文档，另外 rerun 失败需要通过 comment 来告知开发者

cc @swgu98 @ooooo-create

WintersMontagne10335 · 2025-12-18T12:29:52Z

一条流水线（workflow，比如 CI、CI build）里有任何一个 job 仍在运行的话，rerun 是没效果的，别发了，我这邮件一直响 😂

我的，不好意思

SigureMo · 2025-12-18T12:33:32Z

我的，不好意思

文档的问题，问下 /re-run all-failed 是在哪个外部文档看到的，我不记得哪里有写过这个，我找时间更新下，如果没有的话我找时间在贡献指南看看是不是有相关内容更新下

ooooo-create · 2025-12-18T12:46:25Z

目前这个 rerun comment 是写在哪里的文档里了？需要更新下文档，另外 rerun 失败需要通过 comment 来告知开发者

cc @swgu98 @ooooo-create

这个目前确实是缺少外部文档记录，需要添加一下，之前应该是别人告诉才知道

WintersMontagne10335 · 2025-12-18T12:46:48Z

一条流水线（workflow，比如 CI、CI build）里有任何一个 job 仍在运行的话，rerun 是没效果的，别发了，我这邮件一直响 😂

只要发这个指令就会响吗，我等全部都跑完再re-run可以不

WintersMontagne10335 · 2025-12-18T16:29:06Z

/re-run all-failed

naive implement

3a8c699

WintersMontagne10335 added 3 commits December 1, 2025 14:10

update

bcbeb54

Merge remote-tracking branch 'upstream/develop' into hackathon9th06planb

1f92a46

update

cb487f9

paddle-bot bot added the contributor External developers label Dec 1, 2025

luotao1 added HappyOpenSource 快乐开源活动issue与PR API Compatibility labels Dec 2, 2025

luotao1 assigned luotao1 and zhwesky2010 Dec 2, 2025

luotao1 mentioned this pull request Dec 2, 2025

【Hackathon 9th】开源贡献个人挑战赛冲刺赛 #76333

Open

WintersMontagne10335 added 2 commits December 2, 2025 06:19

update

f582b9f

Merge remote-tracking branch 'upstream/develop' into hackathon9th06planb

b63d45d

WintersMontagne10335 added 5 commits December 2, 2025 15:18

update

d2cf355

Merge remote-tracking branch 'upstream/develop' into hackathon9th06planb

5f77217

Merge remote-tracking branch 'upstream/develop' into hackathon9th06planb

5096c40

update

ff24ce3

Merge remote-tracking branch 'upstream/develop' into hackathon9th06planb

e15c147

WintersMontagne10335 requested review from juncaipeng and zhangting2020 as code owners December 5, 2025 13:19

WintersMontagne10335 added 5 commits December 6, 2025 03:39

update

32c16f6

Merge remote-tracking branch 'upstream/develop' into hackathon9th06planb

4fbc263

update

1953589

update

9a2de36

Merge remote-tracking branch 'upstream/develop' into hackathon9th06planb

f8e0db9

zhwesky2010 reviewed Dec 8, 2025

View reviewed changes

zhwesky2010 reviewed Dec 15, 2025

View reviewed changes

WintersMontagne10335 added 4 commits December 15, 2025 17:30

Merge remote-tracking branch 'upstream/develop' into hackathon9th06planb

48601cd

Sink the judgment logic down to the C++ layer

b2bd396

update

22a69c6

update

719e8a9

WintersMontagne10335 requested review from DrRyanHuang, SigureMo, gouzil and zrr1999 as code owners December 15, 2025 19:03

WintersMontagne10335 mentioned this pull request Dec 17, 2025

unary.cc 的 config.is_runtime 在哪设置的 #76941

Closed

zhwesky2010 reviewed Dec 17, 2025

View reviewed changes

WintersMontagne10335 added 2 commits December 18, 2025 09:00

update op_build_gen

0898713

Merge remote-tracking branch 'upstream/develop' into hackathon9th06planb

b51d436

【Hackathon 9th Sprint No.06】NO.06 paddle.nn.MaxPool2D兼容性增强 #76714

Are you sure you want to change the base?

【Hackathon 9th Sprint No.06】NO.06 paddle.nn.MaxPool2D兼容性增强 #76714

Conversation

WintersMontagne10335 commented Dec 1, 2025

PR Category

PR Types

Description

Uh oh!

paddle-bot bot commented Dec 1, 2025

Uh oh!

codecov-commenter commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

WintersMontagne10335 commented Dec 8, 2025

Uh oh!

zhwesky2010 commented Dec 8, 2025

Uh oh!

zhwesky2010 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

WintersMontagne10335 Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

WintersMontagne10335 commented Dec 8, 2025

Uh oh!

WintersMontagne10335 commented Dec 15, 2025

Uh oh!

WintersMontagne10335 commented Dec 15, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

WintersMontagne10335 Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zhwesky2010 Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zhwesky2010 Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zhwesky2010 Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

WintersMontagne10335 Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

WintersMontagne10335 commented Dec 16, 2025

Uh oh!

zhwesky2010 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

codecov-commenter commented Dec 2, 2025 •

edited

Loading

WintersMontagne10335 Dec 10, 2025 •

edited

Loading

WintersMontagne10335 Dec 15, 2025 •

edited

Loading

zhwesky2010 Dec 15, 2025 •

edited

Loading

zhwesky2010 Dec 15, 2025 •

edited

Loading

zhwesky2010 Dec 15, 2025 •

edited

Loading

WintersMontagne10335 Dec 15, 2025 •

edited

Loading

SigureMo commented Dec 18, 2025 •

edited

Loading