-
Notifications
You must be signed in to change notification settings - Fork 5.9k
[CodeStyle][Xdoctest][37,41,44] Fix example code(paddle.Tensor.unflatten,paddle.Tensor.view_as_complex,paddle.audio.datasets.ESC50)
#76794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…ten,paddle.Tensor.view_as_complex,paddle.audio.datasets.ESC50)
|
你的PR提交成功,感谢你对开源项目的贡献! |
|
|
|
先通过 CodeStyle 和 Static check 流水线 |
…ten,paddle.Tensor.view_as_complex,paddle.audio.datasets.ESC50)
c281187 to
8245005
Compare
|
CodeStyle 和 Static check已通过 |
| >>> # doctest: +TIMEOUT(60) | ||
| >>> import paddle | ||
| >>> import warnings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
加这个干什么?这是给用户看的,加这个是跟用户说写代码时候也要 filter 掉 warning 么?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI会用root权限运行pip,pip会针对root的运行提出警告,而CI 把所有警告当错误处理,因此会导致CI错误,我没有想到更好的解决办法
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
啥意思?这里哪里有执行 pip?这不是下载数据集么?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
应该是CI自动化流程执行的pip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这怎么还不删?
| >>> warnings.simplefilter('ignore') | ||
| >>> os.environ['PIP_ROOT_USER_ACTION'] = 'ignore' | ||
| >>> # xdoctest: +SKIP("dataset too large for CI") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
为什么要跳过?是 timeout 还是什么原因?为什么还把 timeout 删掉了???
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里的代码块会加载数据集,但是CI环境里无法下载数据集,就会报错
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
但是CI环境里无法下载数据集,就会报错
指出对应的流水线日志,找不到就重新触发,是否之前能下载现在不能下载我们需要知道原因
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我查阅了很多资料,CI环境中不适合对需要下载外部数据并访问本地文件的功能执行测试,因此跳过是合理的,对应的流水线日志我随后查找一下
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
又是什么大模型给出的离谱解释?让我避避坑
之前能跑现在也需要能跑,不然我们如何保证示例代码的可用性和用户的可复现性?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的,我再重新触发试一下
|
CLA 需要签署 |
8245005 to
b608448
Compare
b608448 to
0f24fc8
Compare
| >>> # doctest: +TIMEOUT(60) | ||
| >>> import paddle | ||
| >>> import warnings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这怎么还不删?
PR Category
User Experience
PR Types
Others
Description
为如下API修复示例代码
Related links
cc @ooooo-create