Skip to content

Conversation

@DanielSun11
Copy link
Contributor

@DanielSun11 DanielSun11 commented Dec 9, 2025

PR Category

Operator Mechanism

PR Types

Improvements

Description

  • 迁移incubate下的swiglu api到 python/paddle/nn/functional/activation.py
  • 为了保证auto parallel ci正常能过,暂时保留paddle.incubate.nn.functional.swiglu 的调用,标记为deprecated,不久就会删除

@paddle-bot
Copy link

paddle-bot bot commented Dec 9, 2025

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@589c2f8). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...addle/distributed/auto_parallel/static/pir_pass.py 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (85.71%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop   #76833   +/-   ##
==========================================
  Coverage           ?   85.71%           
==========================================
  Files              ?        3           
  Lines              ?        7           
  Branches           ?        0           
==========================================
  Hits               ?        6           
  Misses             ?        1           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DanielSun11 DanielSun11 changed the title Migrate swiglu from incubate [fluid_ops]Migrate swiglu from incubate Dec 10, 2025
@DanielSun11 DanielSun11 changed the title [fluid_ops]Migrate swiglu from incubate Migrate swiglu from incubate Dec 11, 2025
@DanielSun11 DanielSun11 changed the title Migrate swiglu from incubate Migrate swiglu from incubate[fluid_ops] Dec 12, 2025
@DanielSun11 DanielSun11 changed the title Migrate swiglu from incubate[fluid_ops] Migrate swiglu from incubate to nn.functional Dec 15, 2025
@DanielSun11 DanielSun11 changed the title Migrate swiglu from incubate to nn.functional Migrate swiglu from incubate to nn.functional[fluid_ops] Dec 15, 2025
@DanielSun11 DanielSun11 changed the title Migrate swiglu from incubate to nn.functional[fluid_ops] Migrate swiglu from incubate to nn.functional Dec 16, 2025
zhangbo9674
zhangbo9674 previously approved these changes Dec 16, 2025
zrr1999
zrr1999 previously approved these changes Dec 16, 2025
Copy link
Member

@zrr1999 zrr1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

"cal_aux_loss",
"build_src_rank_and_local_expert_id",
"int_bincount",
"swiglu",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because we no longer recommend using paddle.incubate.nn.functional.swiglu in the future, it can be removed from __all__ list here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Removed 'swiglu' from the list of functional exports.
@DanielSun11 DanielSun11 dismissed stale reviews from zrr1999 and zhangbo9674 via f941202 December 16, 2025 09:07
@DanielSun11 DanielSun11 changed the title Migrate swiglu from incubate to nn.functional Migrate swiglu from incubate to nn.functional[fluid_ops] Dec 16, 2025
Copy link
Contributor

@jeff41404 jeff41404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielSun11 DanielSun11 merged commit dd5c298 into PaddlePaddle:develop Dec 17, 2025
173 of 191 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants