-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Migrate swiglu from incubate to nn.functional[fluid_ops] #76833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
你的PR提交成功,感谢你对开源项目的贡献! |
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (85.71%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #76833 +/- ##
==========================================
Coverage ? 85.71%
==========================================
Files ? 3
Lines ? 7
Branches ? 0
==========================================
Hits ? 6
Misses ? 1
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zrr1999
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| "cal_aux_loss", | ||
| "build_src_rank_and_local_expert_id", | ||
| "int_bincount", | ||
| "swiglu", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because we no longer recommend using paddle.incubate.nn.functional.swiglu in the future, it can be removed from __all__ list here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Removed 'swiglu' from the list of functional exports.
f941202
jeff41404
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Category
Operator Mechanism
PR Types
Improvements
Description
python/paddle/nn/functional/activation.pypaddle.incubate.nn.functional.swiglu的调用,标记为deprecated,不久就会删除