-
Notifications
You must be signed in to change notification settings - Fork 5.9k
[PIR][N/N] Add CustomPyOP IR #76888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
[PIR][N/N] Add CustomPyOP IR #76888
Conversation
|
你的PR提交成功,感谢你对开源项目的贡献! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
统一一下命名吧:
- dialect name 为
py_op - 在文件名等一些非缩写场景,使用
python_operator,两者一起不缩写
避免和 custom op 相互之间冲突
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lower 后的 kernel dialect 叫啥合适呢?之前叫 custom_py_func,改成 python_operator_function ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
自定义算子的叫啥?
paddle/phi/api/ext/op_meta_info.h
Outdated
|
|
||
| #include "paddle/common/exception.h" | ||
| #include "paddle/common/macros.h" | ||
| #include "paddle/fluid/pir/dialect/operator/ir/ir_tensor.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
phi 不要 include fluid
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (4.75%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #76888 +/- ##
==========================================
Coverage ? 4.75%
==========================================
Files ? 16
Lines ? 484
Branches ? 0
==========================================
Hits ? 23
Misses ? 461
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PR Category
Execute Infrastructure
PR Types
New features
Description
添加 CustomPyOp 与 CustomPyOpDialect
并给 OpMetaInfo 添加 PyOp 实际执行函数与其 InferMeta 函数