Skip to content

Conversation

@DrRyanHuang
Copy link
Contributor

PR Category

Execute Infrastructure

PR Types

New features

Description

添加 CustomPyOp 与 CustomPyOpDialect
并给 OpMetaInfo 添加 PyOp 实际执行函数与其 InferMeta 函数

@paddle-bot
Copy link

paddle-bot bot commented Dec 12, 2025

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

统一一下命名吧:

  • dialect name 为 py_op
  • 在文件名等一些非缩写场景,使用 python_operator,两者一起不缩写

避免和 custom op 相互之间冲突

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lower 后的 kernel dialect 叫啥合适呢?之前叫 custom_py_func,改成 python_operator_function ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

自定义算子的叫啥?


#include "paddle/common/exception.h"
#include "paddle/common/macros.h"
#include "paddle/fluid/pir/dialect/operator/ir/ir_tensor.h"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phi 不要 include fluid

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2025

Codecov Report

❌ Patch coverage is 4.75207% with 461 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@3430fe8). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...struction/python_operation_function_instruction.cc 0.00% 206 Missing ⚠️
paddle/fluid/pir/dialect/operator/ir/op_dialect.cc 0.00% 83 Missing ⚠️
...addle/fluid/pir/transforms/pd_op_to_kernel_pass.cc 3.57% 54 Missing ⚠️
...ddle/fluid/pir/dialect/kernel/ir/kernel_dialect.cc 20.58% 27 Missing ⚠️
paddle/fluid/framework/python_operator.cc 0.00% 23 Missing ⚠️
paddle/fluid/framework/custom_operator_utils.h 0.00% 21 Missing ⚠️
paddle/phi/api/lib/op_meta_info.cc 0.00% 17 Missing ⚠️
paddle/fluid/pir/dialect/kernel/ir/kernel_op.cc 0.00% 16 Missing ⚠️
...le/fluid/framework/new_executor/pir_interpreter.cc 0.00% 5 Missing ⚠️
paddle/fluid/pir/dialect/operator/ir/op_dialect.h 37.50% 5 Missing ⚠️
... and 3 more

❌ Your patch status has failed because the patch coverage (4.75%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop   #76888   +/-   ##
==========================================
  Coverage           ?    4.75%           
==========================================
  Files              ?       16           
  Lines              ?      484           
  Branches           ?        0           
==========================================
  Hits               ?       23           
  Misses             ?      461           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants