Skip to content

perf: optimize checkCapslock method #2635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 8, 2020
Merged

perf: optimize checkCapslock method #2635

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0294a72
optimize checkCapslock method
shangTou Oct 8, 2019
04134dd
update
PanJiaChen Jan 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
optimize checkCapslock method
  • Loading branch information
@shangTou
shangTou committed Oct 8, 2019
commit 0294a72b337faaa7cfaf1d95f34745806aa5ffa3
11 changes: 1 addition & 10 deletions src/views/login/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,16 +139,7 @@ export default {
},
methods: {
checkCapslock({ shiftKey, key } = {}) {
if (key && key.length === 1) {
if (shiftKey && (key >= 'a' && key <= 'z') || !shiftKey && (key >= 'A' && key <= 'Z')) {
this.capsTooltip = true
} else {
this.capsTooltip = false
}
}
if (key === 'CapsLock' && this.capsTooltip === true) {
this.capsTooltip = false
}
this.capsTooltip = key && key.length === 1 && ((shiftKey && (key >= 'A' && key <= 'Z')) || (!shiftKey && (key >= 'A' && key <= 'Z')))
},
showPwd() {
if (this.passwordType === 'password') {
Expand Down